From c75624fbdc72a12c85ead6f390015fffd7d58d78 Mon Sep 17 00:00:00 2001 From: Matt Clay Date: Wed, 3 Jan 2024 17:18:43 -0800 Subject: [PATCH] ansible-test - Enable shellcheck SC2164 --- changelogs/fragments/ansible-test-shellcheck-exclude.yml | 3 +++ .../_util/controller/sanity/shellcheck/exclude.txt | 1 - 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/ansible-test-shellcheck-exclude.yml diff --git a/changelogs/fragments/ansible-test-shellcheck-exclude.yml b/changelogs/fragments/ansible-test-shellcheck-exclude.yml new file mode 100644 index 00000000000..8bf9aa9b812 --- /dev/null +++ b/changelogs/fragments/ansible-test-shellcheck-exclude.yml @@ -0,0 +1,3 @@ +minor_changes: + - ansible-test - The ``shellcheck`` sanity test no longer disables the ``SC2164`` check. + In most cases, seeing this error means the script is missing ``set -e``. diff --git a/test/lib/ansible_test/_util/controller/sanity/shellcheck/exclude.txt b/test/lib/ansible_test/_util/controller/sanity/shellcheck/exclude.txt index 29588ddd861..6563f8fbbf3 100644 --- a/test/lib/ansible_test/_util/controller/sanity/shellcheck/exclude.txt +++ b/test/lib/ansible_test/_util/controller/sanity/shellcheck/exclude.txt @@ -1,3 +1,2 @@ SC1090 SC1091 -SC2164