From bebc192c3e5dee7a55a121affca63434a27997c3 Mon Sep 17 00:00:00 2001 From: Alexei Znamensky <103110+russoz@users.noreply.github.com> Date: Thu, 3 Oct 2024 02:53:58 +1300 Subject: [PATCH] remove one ignore clause for module copy (#83643) --------- Co-authored-by: flowerysong --- changelogs/fragments/83643-fix-sanity-ignore-for-copy.yml | 3 +++ lib/ansible/modules/copy.py | 3 +-- test/sanity/ignore.txt | 1 - 3 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 changelogs/fragments/83643-fix-sanity-ignore-for-copy.yml diff --git a/changelogs/fragments/83643-fix-sanity-ignore-for-copy.yml b/changelogs/fragments/83643-fix-sanity-ignore-for-copy.yml new file mode 100644 index 00000000000..07d6312cb4d --- /dev/null +++ b/changelogs/fragments/83643-fix-sanity-ignore-for-copy.yml @@ -0,0 +1,3 @@ +minor_changes: + - copy - parameter ``local_follow`` was incorrectly documented as having default value ``True`` (https://github.com/ansible/ansible/pull/83643). + - copy - fix sanity test failures (https://github.com/ansible/ansible/pull/83643). diff --git a/lib/ansible/modules/copy.py b/lib/ansible/modules/copy.py index 0a1dc7f7717..bb9ea0493d3 100644 --- a/lib/ansible/modules/copy.py +++ b/lib/ansible/modules/copy.py @@ -109,7 +109,6 @@ options: description: - This flag indicates that filesystem links in the source tree, if they exist, should be followed. type: bool - default: yes version_added: '2.4' checksum: description: @@ -516,7 +515,7 @@ def main(): force=dict(type='bool', default=True), validate=dict(type='str'), directory_mode=dict(type='raw'), - remote_src=dict(type='bool'), + remote_src=dict(type='bool', default=False), local_follow=dict(type='bool'), checksum=dict(type='str'), follow=dict(type='bool', default=False), diff --git a/test/sanity/ignore.txt b/test/sanity/ignore.txt index 1526641f9de..c252426ddbe 100644 --- a/test/sanity/ignore.txt +++ b/test/sanity/ignore.txt @@ -13,7 +13,6 @@ lib/ansible/modules/command.py validate-modules:doc-default-does-not-match-spec lib/ansible/modules/command.py validate-modules:doc-missing-type lib/ansible/modules/command.py validate-modules:nonexistent-parameter-documented lib/ansible/modules/command.py validate-modules:undocumented-parameter -lib/ansible/modules/copy.py validate-modules:doc-default-does-not-match-spec lib/ansible/modules/copy.py validate-modules:nonexistent-parameter-documented lib/ansible/modules/copy.py validate-modules:undocumented-parameter lib/ansible/modules/dnf.py validate-modules:parameter-invalid