From bd4f08823d434193bfcbda8586f4a725c8e05873 Mon Sep 17 00:00:00 2001
From: Sloane Hertel <shertel@redhat.com>
Date: Tue, 8 Aug 2017 12:18:02 -0400
Subject: [PATCH] [cloud] Cleanup of elasticache argspec (#27890)

Remove unnecessary specifications from the argument spec and use dict() instead of brackets for module uniformity.
---
 .../modules/cloud/amazon/elasticache.py       | 28 +++++++++----------
 1 file changed, 14 insertions(+), 14 deletions(-)

diff --git a/lib/ansible/modules/cloud/amazon/elasticache.py b/lib/ansible/modules/cloud/amazon/elasticache.py
index 374e12239c6..de56898adbd 100644
--- a/lib/ansible/modules/cloud/amazon/elasticache.py
+++ b/lib/ansible/modules/cloud/amazon/elasticache.py
@@ -484,21 +484,21 @@ def main():
     """ elasticache ansible module """
     argument_spec = ec2_argument_spec()
     argument_spec.update(dict(
-        state={'required': True, 'choices': ['present', 'absent', 'rebooted']},
-        name={'required': True},
-        engine={'required': False, 'default': 'memcached'},
-        cache_engine_version={'required': False, 'default': ""},
-        node_type={'required': False, 'default': 'cache.t2.small'},
-        num_nodes={'required': False, 'default': 1, 'type': 'int'},
+        state=dict(required=True, choices=['present', 'absent', 'rebooted']),
+        name=dict(required=True),
+        engine=dict(default='memcached'),
+        cache_engine_version=dict(default=""),
+        node_type=dict(default='cache.t2.small'),
+        num_nodes=dict(default=1, type='int'),
         # alias for compat with the original PR 1950
-        cache_parameter_group={'required': False, 'default': "", 'aliases': ['parameter_group']},
-        cache_port={'required': False, 'type': 'int', 'default': None},
-        cache_subnet_group={'required': False, 'default': ""},
-        cache_security_groups={'required': False, 'default': [], 'type': 'list'},
-        security_group_ids={'required': False, 'default': [], 'type': 'list'},
-        zone={'required': False, 'default': ""},
-        wait={'required': False, 'default': True, 'type': 'bool'},
-        hard_modify={'required': False, 'default': False, 'type': 'bool'}
+        cache_parameter_group=dict(default="", aliases=['parameter_group']),
+        cache_port=dict(type='int'),
+        cache_subnet_group=dict(default=""),
+        cache_security_groups=dict(default=[], type='list'),
+        security_group_ids=dict(default=[], type='list'),
+        zone=dict(default=""),
+        wait=dict(default=True, type='bool'),
+        hard_modify=dict(type='bool')
     ))
 
     module = AnsibleModule(