From c4cbeeffa89a6265483c187f493bc90ef13bbac9 Mon Sep 17 00:00:00 2001 From: Karthik T Date: Mon, 11 Jan 2016 16:30:52 +0800 Subject: [PATCH] Fixes #13763 Update connections _play_context on every iteration If this isnt updated, the _connection is reused, and thus has an outdated _play_context This results in outdated `success_key` and `prompt` causing issues if sudo is run in a loop Refer to the issue #13763 for more debugging and details --- lib/ansible/executor/task_executor.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/lib/ansible/executor/task_executor.py b/lib/ansible/executor/task_executor.py index 4a2d30a2cd2..9b7ac8b1563 100644 --- a/lib/ansible/executor/task_executor.py +++ b/lib/ansible/executor/task_executor.py @@ -365,6 +365,9 @@ class TaskExecutor: if not self._connection or not getattr(self._connection, 'connected', False): self._connection = self._get_connection(variables=variables, templar=templar) self._connection.set_host_overrides(host=self._host) + #If connection is reused, its _play_context is no longer valid and needs to be replaced + #This fixes issues with tasks running sudo in a loop and having the success_key incorrect in the second iteration + self._connection._play_context = self._play_context self._handler = self._get_action_handler(connection=self._connection, templar=templar)