Be strict about what is a boolean for keywords (#67625)

* be strict about what is a boolean for keywords

 - found and fixed typo in test , 'yes' != 'yes.'

changelogs/fragments/play_bools_strict.yml

@@ -0,0 +1,2 @@
+bugfixes:
+    - Ensure that keywords defined as booleans are correctly interpreting their input, before patch any random string would be interpreted as False

docs/docsite/rst/porting_guides/porting_guide_2.10.rst

@@ -23,7 +23,8 @@ This document is part of a collection on porting. The complete list of porting g
 Playbook
 ========
 
-No notable changes
+* Fixed a bug on boolean keywords that made random strings return 'False', now they should return an error if they are not a proper boolean
+  Example: `diff: yes-` was returning `False`.
 
 
 Command Line

lib/ansible/playbook/base.py

@@ -343,7 +343,7 @@ class FieldAttributeBase(with_metaclass(BaseMeta, object)):
         elif attribute.isa == 'float':
             value = float(value)
         elif attribute.isa == 'bool':
-            value = boolean(value, strict=False)
+            value = boolean(value, strict=True)
         elif attribute.isa == 'percent':
             # special value, which may be an integer or float
             # with an optional '%' at the end

test/integration/targets/incidental_xml/tasks/test-children-elements-xml.yml

@@ -19,7 +19,7 @@
       src: results/test-add-children-elements.xml
       dest: /tmp/ansible-xml-beers.xml
     check_mode: yes
-    diff: yes·
+    diff: yes
     register: comparison
 
   - name: Test expected result

test/integration/targets/playbook/aliases

@@ -0,0 +1 @@
+shippable/posix/group1

test/integration/targets/playbook/runme.sh

@@ -0,0 +1,6 @@
+#!/usr/bin/env bash
+
+set -eux
+
+# run type tests
+ansible-playbook -i ../../inventory types.yml -v "$@"

test/integration/targets/playbook/types.yml

@@ -0,0 +1,21 @@
+- hosts: testhost
+  gather_facts: false
+  tasks:
+    - name: try to set 'diff' a boolean
+      debug: msg="not important"
+      diff: yes
+      ignore_errors: True
+      register: good_diff
+
+    - name: try to set 'diff' a boolean to a string (. would make it non boolean)
+      debug: msg="not important"
+      diff: yes.
+      ignore_errors: True
+      register: bad_diff
+
+    - name: Check we did error out
+      assert:
+        that:
+            - good_diff is success
+            - bad_diff is failed
+            - "'is not a valid boolean' in bad_diff['msg']"