From b98e6663e8cdd29eecb6614ae12a814df972441e Mon Sep 17 00:00:00 2001 From: dagnello Date: Mon, 8 Jun 2015 18:27:40 -0700 Subject: [PATCH] Minor fixes for os_security_group_rule module Was not able to use this module as it was. The changes submitted resolved the issues I ran into in order to get it working. --- cloud/openstack/os_security_group_rule.py | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/cloud/openstack/os_security_group_rule.py b/cloud/openstack/os_security_group_rule.py index fc5397439c0..efbc41f1148 100644 --- a/cloud/openstack/os_security_group_rule.py +++ b/cloud/openstack/os_security_group_rule.py @@ -99,14 +99,14 @@ def _get_rule_from_group(module, secgroup): def main(): argument_spec = openstack_full_argument_spec( - security_group = dict(required=True), - protocol = dict(default='tcp', choices=['tcp', 'udp', 'icmp']), - port_range_min = dict(required=True), - port_range_max = dict(required=True), - remote_ip_prefix = dict(required=False, default=None), + security_group = dict(required=True), + protocol = dict(default='tcp', choices=['tcp', 'udp', 'icmp']), + port_range_min = dict(required=True), + port_range_max = dict(required=True), + remote_ip_prefix = dict(required=False, default=None), # TODO(mordred): Make remote_group handle name and id - remote_group = dict(required=False, default=None), - state = dict(default='present', choices=['absent', 'present']), + remote_group = dict(required=False, default=None), + state = dict(default='present', choices=['absent', 'present']), ) module_kwargs = openstack_module_kwargs( mutually_exclusive=[ @@ -157,4 +157,4 @@ def main(): from ansible.module_utils.basic import * from ansible.module_utils.openstack import * -main() \ No newline at end of file +main()