From b964c46235b579ddb2825ab3823bc7f5e9f6ae1c Mon Sep 17 00:00:00 2001
From: Christian Kotte <christian.kotte@gmx.de>
Date: Wed, 14 Nov 2018 10:13:48 +0100
Subject: [PATCH] Remove datacenter_name option from vmware_host_datastore
 (#47824)

The datacenter name isn't required to create a NFS or VMFS datastore.
The option isn't available in the spec.
---
 .../modules/cloud/vmware/vmware_host_datastore.py     | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/lib/ansible/modules/cloud/vmware/vmware_host_datastore.py b/lib/ansible/modules/cloud/vmware/vmware_host_datastore.py
index d8c2cac42dc..f8f707f6195 100644
--- a/lib/ansible/modules/cloud/vmware/vmware_host_datastore.py
+++ b/lib/ansible/modules/cloud/vmware/vmware_host_datastore.py
@@ -37,7 +37,9 @@ options:
   datacenter_name:
     description:
     - Name of the datacenter to add the datastore.
-    required: true
+    - The datacenter isn't used by the API to create a datastore.
+    - Will be removed in 2.11.
+    required: false
   datastore_name:
     description:
     - Name of the datastore to add/remove.
@@ -89,7 +91,6 @@ EXAMPLES = r'''
       hostname: '{{ vcenter_hostname }}'
       username: '{{ vcenter_username }}'
       password: '{{ vcenter_password }}'
-      datacenter_name: '{{ datacenter }}'
       datastore_name: '{{ item.name }}'
       datastore_type: '{{ item.type }}'
       vmfs_device_name: 'naa.XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX'
@@ -103,7 +104,6 @@ EXAMPLES = r'''
       hostname: '{{ vcenter_hostname }}'
       username: '{{ vcenter_username }}'
       password: '{{ vcenter_password }}'
-      datacenter_name: '{{ datacenter }}'
       datastore_name: '{{ item.name }}'
       datastore_type: '{{ item.type }}'
       nfs_server: '{{ item.server }}'
@@ -121,7 +121,6 @@ EXAMPLES = r'''
       hostname: '{{ vcenter_hostname }}'
       username: '{{ vcenter_username }}'
       password: '{{ vcenter_password }}'
-      datacenter_name: '{{ datacenter }}'
       datastore_name: '{{ item.name }}'
       datastore_type: '{{ item.type }}'
       nfs_server: '{{ item.server }}'
@@ -139,7 +138,6 @@ EXAMPLES = r'''
       hostname: '{{ vcenter_hostname }}'
       username: '{{ vcenter_username }}'
       password: '{{ vcenter_password }}'
-      datacenter_name: '{{ datacenter }}'
       datastore_name: NasDS_vol01
       esxi_hostname: '{{ inventory_hostname }}'
       state: absent
@@ -163,6 +161,7 @@ class VMwareHostDatastore(PyVmomi):
     def __init__(self, module):
         super(VMwareHostDatastore, self).__init__(module)
 
+        # NOTE: The below parameter is deprecated starting from Ansible v2.11
         self.datacenter_name = module.params['datacenter_name']
         self.datastore_name = module.params['datastore_name']
         self.datastore_type = module.params['datastore_type']
@@ -284,7 +283,7 @@ class VMwareHostDatastore(PyVmomi):
 def main():
     argument_spec = vmware_argument_spec()
     argument_spec.update(
-        datacenter_name=dict(type='str', required=True),
+        datacenter_name=dict(type='str', required=False, removed_in_version=2.11),
         datastore_name=dict(type='str', required=True),
         datastore_type=dict(type='str', choices=['nfs', 'nfs41', 'vmfs']),
         nfs_server=dict(type='str'),