From b86762c1806aa7f021a4780d06db2d3937910a62 Mon Sep 17 00:00:00 2001 From: Jonathan Mainguy Date: Fri, 23 Oct 2015 13:24:39 -0400 Subject: [PATCH] Change show_diff to default to yes, to match what puppet agent --test is, since the rest of the options defaulted to on are grabbed from --test --- system/puppet.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/system/puppet.py b/system/puppet.py index 48a497c37ce..ff5333d3ee1 100644 --- a/system/puppet.py +++ b/system/puppet.py @@ -45,9 +45,9 @@ options: default: None show_diff: description: - - Should puppet return diffs of changes applied. Defaults to off to avoid leaking secret changes by default. + - Should puppet return diffs of changes applied. Defaults to yes, to match puppet agent --test. Change to no to avoid leaking secret changes. required: false - default: no + default: yes choices: [ "yes", "no" ] facts: description: @@ -109,7 +109,7 @@ def main(): puppetmaster=dict(required=False, default=None), manifest=dict(required=False, default=None), show_diff=dict( - default=False, aliases=['show-diff'], type='bool'), + default=True, aliases=['show-diff'], type='bool'), facts=dict(default=None), facter_basename=dict(default='ansible'), environment=dict(required=False, default=None),