Clean up more linting errors for nxos modules (#62069)

This removes a few unused variables and duplicate functions being
defined.

Signed-off-by: Paul Belanger <pabelanger@redhat.com>

lib/ansible/module_utils/network/nxos/config/telemetry/telemetry.py

@@ -152,11 +152,6 @@ class Telemetry(ConfigBase):
         ref.get_playvals()
         device_cache = ref.cache_existing
 
-        if device_cache is None:
-            device_cache_lines = []
-        else:
-            device_cache_lines = device_cache.split("\n")
-
         # Get Telemetry Destination Group Data
         if want.get('destination_groups'):
             td = {'name': 'destination_groups', 'type': 'TMS_DESTGROUP',

lib/ansible/module_utils/network/nxos/facts/lacp/lacp.py

@@ -45,7 +45,6 @@ class LacpFacts(object):
         :rtype: dictionary
         :returns: facts
         """
-        obj = []
         if not data:
             data = connection.get("show running-config | include lacp")
         resources = data.strip()

lib/ansible/module_utils/network/nxos/facts/legacy/base.py

@@ -76,11 +76,6 @@ class Default(FactsBase):
         if match:
             return match.group(1)
 
-    def parse_license_hostid(self, data):
-        match = re.search(r'License hostid: VDH=(.+)$', data, re.M)
-        if match:
-            return match.group(1)
-
     def platform_facts(self):
         platform_facts = {}
 

lib/ansible/module_utils/network/nxos/nxos.py

@@ -1116,8 +1116,6 @@ class NxosCmdRef:
 
             # Multiple Instances:
             if isinstance(existing, dict) and multiple:
-                item_found = False
-
                 for ekey, evalue in existing.items():
                     if isinstance(evalue, dict):
                         # Remove values set to string 'None' from dvalue

lib/ansible/modules/network/nxos/_nxos_interface.py

@@ -316,7 +316,7 @@ def is_default_interface(name, module):
 
     try:
         body = execute_show_command(command, module)[0]
-    except (IndexError, TypeError) as e:
+    except (IndexError, TypeError):
         body = ''
 
     if body:
@@ -535,7 +535,6 @@ def map_config_to_obj(want, module):
                     obj['description'] = interface_table.get('desc')
                     obj['mtu'] = interface_table.get('eth_mtu')
                     obj['duplex'] = interface_table.get('eth_duplex')
-                    speed = interface_table.get('eth_speed')
 
                     command = 'show run interface {0}'.format(obj['name'])
                     body = execute_show_command(command, module)[0]

lib/ansible/modules/network/nxos/nxos_bgp_neighbor_af.py

@@ -338,11 +338,6 @@ def get_custom_value(arg, config, module):
     splitted_config = config.splitlines()
     value = ''
 
-    command_re = re.compile(r'\s+{0}\s*'.format(command), re.M)
-    has_command = command_re.search(config)
-    command_val_re = re.compile(r'(?:{0}\s)(?P<value>.*)$'.format(command), re.M)
-    has_command_val = command_val_re.search(config)
-
     if arg.startswith('additional_paths'):
         value = 'inherit'
         for line in splitted_config:

lib/ansible/modules/network/nxos/nxos_gir.py

@@ -188,7 +188,6 @@ def get_reset_reasons(module):
 
 def get_commands(module, state, mode):
     commands = list()
-    system_mode = ''
     if module.params['system_mode_maintenance'] is True and mode == 'normal':
         commands.append('system mode maintenance')
     elif (module.params['system_mode_maintenance'] is False and

lib/ansible/modules/network/nxos/nxos_igmp.py

@@ -121,7 +121,6 @@ def main():
     desired = get_desired(module)
 
     state = module.params['state']
-    restart = module.params['restart']
 
     commands = list()
 

lib/ansible/modules/network/nxos/nxos_pim_interface.py

@@ -289,7 +289,6 @@ def get_pim_interface(module, interface):
             elif 'sparse-mode' in each:
                 pim_interface['sparse'] = True
             elif 'bfd-instance' in each:
-                value = 'default'
                 m = re.search(r'ip pim bfd-instance(?P<disable> disable)?', each)
                 if m:
                     pim_interface['bfd'] = 'disable' if m.group('disable') else 'enable'
@@ -509,7 +508,6 @@ def main():
     jp_policy_out = module.params['jp_policy_out']
     neighbor_policy = module.params['neighbor_policy']
     neighbor_type = module.params['neighbor_type']
-    hello_interval = module.params['hello_interval']
 
     intf_type = get_interface_type(interface)
     if get_interface_mode(interface, intf_type, module) == 'layer2':

lib/ansible/modules/network/nxos/nxos_ping.py

@@ -192,7 +192,6 @@ def main():
     check_args(module, warnings)
 
     destination = module.params['dest']
-    count = module.params['count']
     state = module.params['state']
 
     ping_command = 'ping {0}'.format(destination)

lib/ansible/modules/network/nxos/nxos_user.py

@@ -160,7 +160,6 @@ def validate_roles(value, module):
 
 def map_obj_to_commands(updates, module):
     commands = list()
-    state = module.params['state']
     update_password = module.params['update_password']
 
     for update in updates:

lib/ansible/modules/network/nxos/nxos_vrf_interface.py

@@ -210,12 +210,9 @@ def main():
                              'configuring a VRF on an interface. You can '
                              'use nxos_interface')
 
-    proposed = dict(interface=interface, vrf=vrf)
-
     current_vrf = get_interface_info(interface, module)
     existing = dict(interface=interface, vrf=current_vrf)
     changed = False
-    end_state = existing
 
     if not existing['vrf']:
         pass
@@ -247,8 +244,6 @@ def main():
         else:
             load_config(module, commands)
             changed = True
-            changed_vrf = get_interface_info(interface, module)
-            end_state = dict(interface=interface, vrf=changed_vrf)
             if 'configure' in commands:
                 commands.pop(0)
 

lib/ansible/modules/network/nxos/nxos_vrrp.py

@@ -377,8 +377,6 @@ def main():
     proposed = dict((k, v) for k, v in args.items() if v is not None)
     existing = get_existing_vrrp(interface, group, module, name)
 
-    changed = False
-    end_state = existing
     commands = []
 
     if state == 'present':

lib/ansible/plugins/action/nxos_file_copy.py

@@ -191,7 +191,6 @@ class ActionModule(ActionBase):
         timeout = self.socket_timeout
         local_file = self.playvals['local_file']
         file_system = self.playvals['file_system']
-        file_size = os.path.getsize(local_file)
 
         if not self.enough_space(local_file, file_system):
             raise AnsibleError('Could not transfer file. Not enough space on device.')