Fixes #51324 azure_rm_publicipaddress not idempotent (#53375)

7 years ago · b6e669f135
parent b906db5f2a
commit b6e669f135
1 changed files with 2 additions and 1 deletions
--- a/lib/ansible/modules/cloud/azure/azure_rm_publicipaddress.py
+++ b/lib/ansible/modules/cloud/azure/azure_rm_publicipaddress.py
@ -236,7 +236,8 @@ class AzureRMPublicIPAddress(AzureRMModuleBase):
            self.log("PIP {0} exists".format(self.name))
            if self.state == 'present':
                results = pip_to_dict(pip)
-                if self.domain_name != results['dns_settings'].get('domain_name_label'):
+                domain_lable = results['dns_settings'].get('domain_name_label')
+                if self.domain_name is not None and ((self.domain_name or domain_lable) and self.domain_name != domain_lable):
                    self.log('CHANGED: domain_name_label')
                    changed = True
                    results['dns_settings']['domain_name_label'] = self.domain_name