diff --git a/lib/ansible/modules/network/vyos/vyos_user.py b/lib/ansible/modules/network/vyos/vyos_user.py new file mode 100644 index 00000000000..305aeeb7e95 --- /dev/null +++ b/lib/ansible/modules/network/vyos/vyos_user.py @@ -0,0 +1,310 @@ +#!/usr/bin/python +# -*- coding: utf-8 -*- + +# (c) 2017, Ansible by Red Hat, inc +# +# This file is part of Ansible by Red Hat +# +# Ansible is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# Ansible is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Ansible. If not, see . +# + +ANSIBLE_METADATA = {'metadata_version': '1.0', + 'status': ['preview'], + 'supported_by': 'core'} + +DOCUMENTATION = """ +--- +module: vyos_user +version_added: "2.4" +author: "Trishna Guha (@trishnag)" +short_description: Manage the collection of local users on VyOS device +description: + - This module provides declarative management of the local usernames + configured on network devices. It allows playbooks to manage + either individual usernames or the collection of usernames in the + current running config. It also supports purging usernames from the + configuration that are not explicitly defined. +options: + users: + description: + - The set of username objects to be configured on the remote + VyOS device. The list entries can either be the username or + a hash of username and properties. This argument is mutually + exclusive with the C(name) argument. + name: + description: + - The username to be configured on the VyOS device. + This argument accepts a string value and is mutually exclusive + with the C(collection) argument. + Please note that this option is not same as C(provider username). + full_name: + description: + - The C(full_name) argument provides the full name of the user + account to be created on the remote device. This argument accepts + any text string value. + password: + description: + - The password to be configured on the VyOS device. The + password needs to be provided in clear and it will be encrypted + on the device. + Please note that this option is not same as C(provider password). + update_password: + description: + - Since passwords are encrypted in the device running config, this + argument will instruct the module when to change the password. When + set to C(always), the password will always be updated in the device + and when set to C(on_create) the password will be updated only if + the username is created. + default: always + choices: ['on_create', 'always'] + level: + description: + - The C(level) argument configures the level of the user when logged + into the system. This argument accepts string values admin or operator. + purge: + description: + - Instructs the module to consider the + resource definition absolute. It will remove any previously + configured usernames on the device with the exception of the + `admin` user (the current defined set of users). + type: bool + default: false + state: + description: + - Configures the state of the username definition + as it relates to the device operational configuration. When set + to I(present), the username(s) should be configured in the device active + configuration and when set to I(absent) the username(s) should not be + in the device active configuration + default: present + choices: ['present', 'absent'] +""" + +EXAMPLES = """ +- name: create a new user + vyos_user: + name: ansible + password: password + state: present +- name: remove all users except admin + vyos_user: + purge: yes +- name: set multiple users to level operator + vyos_user: + users: + - name: netop + - name: netend + level: operator + state: present +- name: Change Password for User netop + vyos_user: + name: netop + password: "{{ new_password }}" + update_password: always + state: present +""" + +RETURN = """ +commands: + description: The list of configuration mode commands to send to the device + returned: always + type: list + sample: + - set system login user test level operator + - set system login user authentication encrypted-password password +""" + +import re + +from functools import partial + +from ansible.module_utils.basic import AnsibleModule +from ansible.module_utils.vyos import get_config, load_config +from ansible.module_utils.six import iteritems +from ansible.module_utils.vyos import vyos_argument_spec, check_args + + +def validate_level(value, module): + if value not in ('admin', 'operator'): + module.fail_json(msg='level must be either admin or operator, got %s' % value) + + +def spec_to_commands(updates, module): + commands = list() + state = module.params['state'] + update_password = module.params['update_password'] + + def needs_update(want, have, x): + return want.get(x) and (want.get(x) != have.get(x)) + + def add(command, want, x): + command.append('set system login user %s %s' % (want['name'], x)) + + for update in updates: + want, have = update + + if want['state'] == 'absent': + commands.append('delete system login user %s' % want['name']) + continue + + if needs_update(want, have, 'level'): + add(commands, want, 'level %s' % want['level']) + + if needs_update(want, have, 'password'): + if update_password == 'always' or not have: + add(commands, want, 'authentication encrypted-password %s' % want['password']) + + return commands + + +def config_to_dict(module): + data = get_config(module) + instances = [] + + config = {'name': [], 'level': [], 'full_name': [], 'password': None, 'state': 'present'} + + for line in data.split('\n'): + if line.startswith('set system login user'): + match = re.findall(r'user (\S+)', line, re.M) + config['name'].extend(match) + if 'level' in line: + match = re.findall(r'level (\S+)', line, re.M) + config['level'].extend(match) + if 'full-name' in line: + match = re.findall(r'full-name (\S+)', line, re.M) + config['full_name'].extend(match) + + instances = [config] + + return instances + + +def get_param_value(key, item, module): + # if key doesn't exist in the item, get it from module.params + if not item.get(key): + value = module.params[key] + + # if key does exist, do a type check on it to validate it + else: + value_type = module.argument_spec[key].get('type', 'str') + type_checker = module._CHECK_ARGUMENT_TYPES_DISPATCHER[value_type] + type_checker(item[key]) + value = item[key] + + # validate the param value (if validator func exists) + validator = globals().get('validate_%s' % key) + if all((value, validator)): + validator(value, module) + + return value + + +def map_params_to_obj(module): + users = module.params['users'] + if not users: + if not module.params['name'] and module.params['purge']: + return list() + elif not module.params['name']: + module.fail_json(msg='username is required') + else: + collection = [{'name': module.params['name']}] + else: + collection = list() + for item in users: + if not isinstance(item, dict): + collection.append({'name': item}) + elif 'name' not in item: + module.fail_json(msg='name is required') + else: + collection.append(item) + + objects = list() + + for item in collection: + get_value = partial(get_param_value, item=item, module=module) + item['password'] = get_value('password') + item['level'] = get_value('level') + item['state'] = get_value('state') + objects.append(item) + + return objects + + +def update_objects(want, have): + updates = list() + + for entry in want: + item = next((i for i in have if i['name'] == entry['name']), None) + if item is None: + updates.append((entry, {})) + elif item: + for key, value in iteritems(entry): + if value and value != item[key]: + updates.append((entry, item)) + return updates + + +def main(): + """ main entry point for module execution + """ + argument_spec = dict( + users=dict(type='list', aliases=['collection']), + name=dict(), + + full_name=dict(), + level=dict(aliases=['role']), + + password=dict(no_log=True), + update_password=dict(default='always', choices=['on_create', 'always']), + + purge=dict(type='bool', default=False), + state=dict(default='present', choices=['present', 'absent']) + ) + + argument_spec.update(vyos_argument_spec) + mutually_exclusive = [('name', 'users')] + + module = AnsibleModule(argument_spec=argument_spec, + mutually_exclusive=mutually_exclusive, + supports_check_mode=True) + + warnings = list() + check_args(module, warnings) + + result = {'changed': False} + if warnings: + result['warnings'] = warnings + + want = map_params_to_obj(module) + have = config_to_dict(module) + commands = spec_to_commands(update_objects(want, have), module) + + if module.params['purge']: + want_users = [x['name'] for x in want] + for x in have: + have_users = x['name'] + for item in set(have_users).difference(want_users): + commands.append('delete system login user %s' % item) + + result['commands'] = commands + + if commands: + commit = not module.check_mode + load_config(module, commands, commit=commit) + result['changed'] = True + + module.exit_json(**result) + +if __name__ == '__main__': + main() diff --git a/test/integration/targets/vyos_user/defaults/main.yaml b/test/integration/targets/vyos_user/defaults/main.yaml new file mode 100644 index 00000000000..9ef5ba51651 --- /dev/null +++ b/test/integration/targets/vyos_user/defaults/main.yaml @@ -0,0 +1,3 @@ +--- +testcase: "*" +test_items: [] diff --git a/test/integration/targets/vyos_user/tasks/cli.yaml b/test/integration/targets/vyos_user/tasks/cli.yaml new file mode 100644 index 00000000000..d675462dd02 --- /dev/null +++ b/test/integration/targets/vyos_user/tasks/cli.yaml @@ -0,0 +1,15 @@ +--- +- name: collect all cli test cases + find: + paths: "{{ role_path }}/tests/cli" + patterns: "{{ testcase }}.yaml" + register: test_cases + +- name: set test_items + set_fact: test_items="{{ test_cases.files | map(attribute='path') | list }}" + +- name: run test case + include: "{{ test_case_to_run }}" + with_items: "{{ test_items }}" + loop_control: + loop_var: test_case_to_run diff --git a/test/integration/targets/vyos_user/tasks/main.yaml b/test/integration/targets/vyos_user/tasks/main.yaml new file mode 100644 index 00000000000..415c99d8b12 --- /dev/null +++ b/test/integration/targets/vyos_user/tasks/main.yaml @@ -0,0 +1,2 @@ +--- +- { include: cli.yaml, tags: ['cli'] } diff --git a/test/integration/targets/vyos_user/tests/cli/basic.yaml b/test/integration/targets/vyos_user/tests/cli/basic.yaml new file mode 100644 index 00000000000..07ce1e37735 --- /dev/null +++ b/test/integration/targets/vyos_user/tests/cli/basic.yaml @@ -0,0 +1,71 @@ +--- +- name: Create user (SetUp) + vyos_user: + name: ansibletest1 + password: test + state: present + provider: "{{ cli }}" + register: result + +- assert: + that: + - 'result.changed == true' + - '"set system login user ansibletest1 authentication plaintext-password" in result.commands' + +- name: Collection of users (SetUp) + vyos_user: + users: + - name: ansibletest2 + - name: ansibletest3 + level: operator + state: present + provider: "{{ cli }}" + register: result + +- assert: + that: + - 'result.changed == true' + - 'result.commands == ["set system login user ansibletest2 level operator", "set system login user ansibletest3 level operator"]' + +- name: Add user again (Idempotent) + vyos_user: + name: ansibletest1 + password: test + state: present + provider: "{{ cli }}" + register: result + +- assert: + that: + - 'result.changed == false' + - 'result.commands | length == 0' + +- name: Add collection of users (Idempotent) + vyos_user: + users: + - name: ansibletest2 + - name: ansibletest3 + level: operator + state: present + provider: "{{ cli }}" + register: result + +- assert: + that: + - 'result.changed == false' + - 'result.commands | length == 0' + +- name: tearDown + vyos_user: + users: + - name: ansibletest1 + - name: ansibletest2 + - name: ansibletest3 + state: absent + provider: "{{ cli }}" + register: result + +- assert: + that: + - 'result.changed == true' + - 'result.commands == ["delete system login user ansibletest1", "delete system login user ansibletest2", "delete system login user ansibletest3"]' diff --git a/test/integration/vyos.yaml b/test/integration/vyos.yaml index 53130baacec..7fd1e6ec1bd 100644 --- a/test/integration/vyos.yaml +++ b/test/integration/vyos.yaml @@ -10,3 +10,4 @@ roles: - { role: vyos_command, when: "limit_to in ['*', 'vyos_command']" } - { role: vyos_config, when: "limit_to in ['*', 'vyos_config']" } + - { role: vyos_user, when: "limit_to in ['*', vyos_user']" } diff --git a/test/units/modules/network/vyos/fixtures/vyos_user_config.cfg b/test/units/modules/network/vyos/fixtures/vyos_user_config.cfg new file mode 100644 index 00000000000..81cd1a48a13 --- /dev/null +++ b/test/units/modules/network/vyos/fixtures/vyos_user_config.cfg @@ -0,0 +1,2 @@ +set system login user admin level operator authentication encrypted-password '$6$V5oWW3JM9NFAwOG$P2L4raFvIrZjjs3g0qmH4Ns5ti7flRpSs6aEqy4TrGZYXGeBiYzwi2A6jy' +set system login user ansible level operator authentication encrypted-password '$6$ZfvSv6A50W6yNPYX$4HP5eg2sywcXYxTqhApQ7zvUvx0HsQHrI9xuJoFLy2gM/' diff --git a/test/units/modules/network/vyos/test_vyos_user.py b/test/units/modules/network/vyos/test_vyos_user.py new file mode 100644 index 00000000000..ec31a0849b4 --- /dev/null +++ b/test/units/modules/network/vyos/test_vyos_user.py @@ -0,0 +1,86 @@ +# (c) 2016 Red Hat Inc. +# +# This file is part of Ansible +# +# Ansible is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# Ansible is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Ansible. If not, see . + +# Make coding more python3-ish +from __future__ import (absolute_import, division, print_function) +__metaclass__ = type + +import json + +from ansible.compat.tests.mock import patch +from ansible.modules.network.vyos import vyos_user +from .vyos_module import TestVyosModule, load_fixture, set_module_args + + +class TestVyosUserModule(TestVyosModule): + + module = vyos_user + + def setUp(self): + self.mock_get_config = patch('ansible.modules.network.vyos.vyos_user.get_config') + self.get_config = self.mock_get_config.start() + + self.mock_load_config = patch('ansible.modules.network.vyos.vyos_user.load_config') + self.load_config = self.mock_load_config.start() + + def tearDown(self): + self.mock_get_config.stop() + self.mock_load_config.stop() + + def load_fixtures(self, commands=None, transport='cli'): + self.get_config.return_value = load_fixture('vyos_user_config.cfg') + self.load_config.return_value = dict(diff=None, session='session') + + def test_vyos_user_password(self): + set_module_args(dict(name='ansible', password='test')) + result = self.execute_module(changed=True) + self.assertEqual(result['commands'], ['set system login user ansible authentication encrypted-password test']) + + def test_vyos_user_delete(self): + set_module_args(dict(name='ansible', state='absent')) + result = self.execute_module(changed=True) + self.assertEqual(result['commands'], ['delete system login user ansible']) + + def test_vyos_user_level(self): + set_module_args(dict(name='ansible', level='operator')) + result = self.execute_module(changed=True) + self.assertEqual(result['commands'], ['set system login user ansible level operator']) + + def test_vyos_user_level_invalid(self): + set_module_args(dict(name='ansible', level='sysadmin')) + self.execute_module(failed=True) + + def test_vyos_user_purge(self): + set_module_args(dict(purge=True)) + result = self.execute_module(changed=True) + self.assertEqual(sorted(result['commands']), sorted(['delete system login user ansible', + 'delete system login user admin'])) + + def test_vyos_user_update_password_changed(self): + set_module_args(dict(name='test', password='test', update_password='on_create')) + result = self.execute_module(changed=True) + self.assertEqual(result['commands'], ['set system login user test authentication encrypted-password test']) + + def test_vyos_user_update_password_on_create_ok(self): + set_module_args(dict(name='ansible', password='test', update_password='on_create')) + result = self.execute_module(changed=True) + self.assertEqual(result['commands'], ['set system login user ansible authentication encrypted-password test']) + + def test_vyos_user_update_password_always(self): + set_module_args(dict(name='ansible', password='test', update_password='always')) + result = self.execute_module(changed=True) + self.assertEqual(result['commands'], ['set system login user ansible authentication encrypted-password test'])