From b2e5c75131e94a3543e5dcf9fb641ccd553906b4 Mon Sep 17 00:00:00 2001 From: Lars Kellogg-Stedman Date: Fri, 30 Nov 2018 06:42:50 -0500 Subject: [PATCH] server.security_groups is a list of dicts (#48798) os_server was trying to access `[sg.name for sg in server.security_groups]`, but the items in `server.security_groups` are dictionaries, so that should be `sg['name']`. --- lib/ansible/modules/cloud/openstack/os_server.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ansible/modules/cloud/openstack/os_server.py b/lib/ansible/modules/cloud/openstack/os_server.py index aacd7b5a4c0..75efe007755 100644 --- a/lib/ansible/modules/cloud/openstack/os_server.py +++ b/lib/ansible/modules/cloud/openstack/os_server.py @@ -625,7 +625,7 @@ def _check_security_groups(module, cloud, server): return changed, server module_security_groups = set(module.params['security_groups']) - server_security_groups = set(sg.name for sg in server.security_groups) + server_security_groups = set(sg['name'] for sg in server.security_groups) add_sgs = module_security_groups - server_security_groups remove_sgs = server_security_groups - module_security_groups