From 981e9c44ba7b18b87eb7c4d21ef0235b5258e42e Mon Sep 17 00:00:00 2001 From: Greg DeKoenigsberg Date: Thu, 21 Jan 2016 12:22:26 -0500 Subject: [PATCH 1/2] Put Python 2.4 in checklist It's in the travis check, but we don't spell it out explicitly in the guidelines. --- docsite/rst/developing_modules.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/docsite/rst/developing_modules.rst b/docsite/rst/developing_modules.rst index f945cc24bca..4be3415d349 100644 --- a/docsite/rst/developing_modules.rst +++ b/docsite/rst/developing_modules.rst @@ -479,6 +479,7 @@ Module checklist ```````````````` * The shebang should always be #!/usr/bin/python, this allows ansible_python_interpreter to work +* Modules must be written to support Python 2.4. * Documentation: Make sure it exists * `required` should always be present, be it true or false * If `required` is false you need to document `default`, even if the default is 'null' (which is the default if no parameter is supplied). Make sure default parameter in docs matches default parameter in code. From f3336fba448bdc37743982b0febce5c210b9249a Mon Sep 17 00:00:00 2001 From: Greg DeKoenigsberg Date: Thu, 21 Jan 2016 13:02:03 -0500 Subject: [PATCH 2/2] Tweaking Python 2.4 requirement --- docsite/rst/developing_modules.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docsite/rst/developing_modules.rst b/docsite/rst/developing_modules.rst index 4be3415d349..dc5b7e8f5ff 100644 --- a/docsite/rst/developing_modules.rst +++ b/docsite/rst/developing_modules.rst @@ -479,7 +479,7 @@ Module checklist ```````````````` * The shebang should always be #!/usr/bin/python, this allows ansible_python_interpreter to work -* Modules must be written to support Python 2.4. +* Modules must be written to support Python 2.4. If this is not possible, required minimum python version and rationale should be explained in the requirements section in DOCUMENTATION. * Documentation: Make sure it exists * `required` should always be present, be it true or false * If `required` is false you need to document `default`, even if the default is 'null' (which is the default if no parameter is supplied). Make sure default parameter in docs matches default parameter in code.