From aadbb6c0b41280a9d83c534816a08b1b72ee7ae1 Mon Sep 17 00:00:00 2001 From: Abhijeet Kasurde Date: Wed, 21 Mar 2018 10:29:46 -0400 Subject: [PATCH] VMware: Handle exception gracefully (#36619) This fix adds logic to handle exception raised from conversion of user parameter 'memory_mb'. Signed-off-by: Abhijeet Kasurde --- lib/ansible/modules/cloud/vmware/vmware_guest.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/ansible/modules/cloud/vmware/vmware_guest.py b/lib/ansible/modules/cloud/vmware/vmware_guest.py index b68a3e31187..e85b5af8193 100644 --- a/lib/ansible/modules/cloud/vmware/vmware_guest.py +++ b/lib/ansible/modules/cloud/vmware/vmware_guest.py @@ -786,7 +786,12 @@ class PyVmomiHelper(PyVmomi): self.module.fail_json(msg="hardware.num_cpus attribute is mandatory for VM creation") if 'memory_mb' in self.params['hardware']: - self.configspec.memoryMB = int(self.params['hardware']['memory_mb']) + try: + self.configspec.memoryMB = int(self.params['hardware']['memory_mb']) + except ValueError: + self.module.fail_json(msg="Failed to parse hardware.memory_mb value." + " Please refer the documentation and provide" + " correct value.") if vm_obj is None or self.configspec.memoryMB != vm_obj.config.hardware.memoryMB: self.change_detected = True # memory_mb is mandatory for VM creation