From aa3975e084f515741729452494b6185784731bf2 Mon Sep 17 00:00:00 2001 From: Ryan Brown Date: Mon, 10 Jul 2017 16:57:37 -0400 Subject: [PATCH] [cloud] Stop CloudFormation module from always making changesets (#26619) In Python a function is always truthy, and the name of the `create_changeset` function was being accidentally used instead of `module.params['changeset']`. --- lib/ansible/modules/cloud/amazon/cloudformation.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ansible/modules/cloud/amazon/cloudformation.py b/lib/ansible/modules/cloud/amazon/cloudformation.py index 88897337c52..b5a23028a4c 100644 --- a/lib/ansible/modules/cloud/amazon/cloudformation.py +++ b/lib/ansible/modules/cloud/amazon/cloudformation.py @@ -518,7 +518,7 @@ def main(): if state == 'present': if not stack_info: result = create_stack(module, stack_params, cfn) - elif create_changeset: + elif module.params.get('create_changeset'): result = create_changeset(module, stack_params, cfn) else: result = update_stack(module, stack_params, cfn)