diff --git a/test/integration/targets/ansible-test-sanity-pylint/runme.sh b/test/integration/targets/ansible-test-sanity-pylint/runme.sh index 386d16c6106..72190bfaa0f 100755 --- a/test/integration/targets/ansible-test-sanity-pylint/runme.sh +++ b/test/integration/targets/ansible-test-sanity-pylint/runme.sh @@ -2,11 +2,6 @@ set -eu -if [ "${ANSIBLE_TEST_PYTHON_VERSION}" = "3.12" ]; then - echo "skipping test, pylint is not supported on Python 3.12" - exit -fi - source ../collection/setup.sh # Create test scenarios at runtime that do not pass sanity tests. diff --git a/test/lib/ansible_test/_data/requirements/sanity.pylint.txt b/test/lib/ansible_test/_data/requirements/sanity.pylint.txt index 8e4ccca119d..f519b37852e 100644 --- a/test/lib/ansible_test/_data/requirements/sanity.pylint.txt +++ b/test/lib/ansible_test/_data/requirements/sanity.pylint.txt @@ -1,13 +1,9 @@ # edit "sanity.pylint.in" and generate with: hacking/update-sanity-requirements.py --test pylint -astroid==2.15.8 +astroid==3.0.0 dill==0.3.7 isort==5.12.0 -lazy-object-proxy==1.9.0 mccabe==0.7.0 -platformdirs==3.10.0 -pylint==2.17.6 +platformdirs==3.11.0 +pylint==3.0.0 PyYAML==6.0.1 -tomli==2.0.1 tomlkit==0.12.1 -typing_extensions==4.8.0 -wrapt==1.15.0 diff --git a/test/lib/ansible_test/_internal/commands/sanity/pylint.py b/test/lib/ansible_test/_internal/commands/sanity/pylint.py index e78a65f4911..54b1952f794 100644 --- a/test/lib/ansible_test/_internal/commands/sanity/pylint.py +++ b/test/lib/ansible_test/_internal/commands/sanity/pylint.py @@ -82,12 +82,6 @@ class PylintTest(SanitySingleVersion): """Error code for ansible-test matching the format used by the underlying test program, or None if the program does not use error codes.""" return 'ansible-test' - @property - def supported_python_versions(self) -> t.Optional[tuple[str, ...]]: - """A tuple of supported Python versions or None if the test does not depend on specific Python versions.""" - # NOTE: When removing the Python 3.12 exclusion, be sure to update the ansible-test-sanity-pylint integration test. - return tuple(version for version in super().supported_python_versions if version != '3.12') - def filter_targets(self, targets: list[TestTarget]) -> list[TestTarget]: """Return the given list of test targets, filtered to include only those relevant for the test.""" return [target for target in targets if os.path.splitext(target.path)[1] == '.py' or is_subdir(target.path, 'bin')] diff --git a/test/sanity/ignore.txt b/test/sanity/ignore.txt index ea0252ed5c6..c683fbe7e2f 100644 --- a/test/sanity/ignore.txt +++ b/test/sanity/ignore.txt @@ -40,6 +40,7 @@ lib/ansible/modules/lineinfile.py validate-modules:doc-default-does-not-match-sp lib/ansible/modules/lineinfile.py validate-modules:nonexistent-parameter-documented lib/ansible/modules/package_facts.py validate-modules:doc-choices-do-not-match-spec lib/ansible/modules/replace.py validate-modules:nonexistent-parameter-documented +lib/ansible/modules/replace.py pylint:used-before-assignment # false positive detection by pylint lib/ansible/modules/service.py validate-modules:nonexistent-parameter-documented lib/ansible/modules/service.py validate-modules:use-run-command-not-popen lib/ansible/modules/stat.py validate-modules:parameter-invalid