From a8bc6f69d906df31b494ec57f93df217db9eafc6 Mon Sep 17 00:00:00 2001 From: Takuya Sato Date: Tue, 17 Oct 2017 21:30:32 +0900 Subject: [PATCH] skip check environment parameter if has no containers. (#31083) * skip check environment parameter if has no containers. * optimize code --- lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py b/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py index 7296218a754..bcbffc6fddc 100644 --- a/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py +++ b/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py @@ -129,6 +129,7 @@ except ImportError: from ansible.module_utils.basic import AnsibleModule from ansible.module_utils.ec2 import boto3_conn, camel_dict_to_snake_dict, ec2_argument_spec, get_aws_connection_info +from ansible.module_utils._text import to_text class EcsTaskManager: """Handles ECS Tasks""" @@ -241,10 +242,9 @@ def main(): task_mgr = EcsTaskManager(module) results = dict(changed=False) - for container in module.params['containers']: - if 'environment' in container: - for environment in container['environment']: - environment['value'] = str(environment['value']) + for container in module.params.get('containers', []): + for environment in container.get('environment', []): + environment['value'] = to_text(environment['value']) if module.params['state'] == 'present': if 'containers' not in module.params or not module.params['containers']: