diff --git a/changelogs/fragments/67813-ovirt_snapshot_fix_disk_snapshot.yml b/changelogs/fragments/67813-ovirt_snapshot_fix_disk_snapshot.yml new file mode 100644 index 00000000000..3e5638ffecd --- /dev/null +++ b/changelogs/fragments/67813-ovirt_snapshot_fix_disk_snapshot.yml @@ -0,0 +1,2 @@ +bugfixes: +- "Fixed explicit disk arguments not resulting in disk snapshots in VM snapshot at all" diff --git a/lib/ansible/modules/cloud/ovirt/ovirt_snapshot.py b/lib/ansible/modules/cloud/ovirt/ovirt_snapshot.py index 77967413362..869fd84f45b 100644 --- a/lib/ansible/modules/cloud/ovirt/ovirt_snapshot.py +++ b/lib/ansible/modules/cloud/ovirt/ovirt_snapshot.py @@ -367,7 +367,7 @@ def create_snapshot(module, vm_service, snapshots_service, connection): otypes.Snapshot( description=module.params.get('description'), persist_memorystate=module.params.get('use_memory'), - disk_attachments=[otypes.DiskAttachment(id=da_id) for da_id in disk_attachments_id] if disk_attachments_id else None + disk_attachments=[otypes.DiskAttachment(disk=otypes.Disk(id=da_id)) for da_id in disk_attachments_id] if disk_attachments_id else None ) ) changed = True