From 9f9a741e19e5b5e7e1f5e88a0447bfaf154a234e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20Angel=20Mu=C3=B1oz=20Gonz=C3=A1lez?= Date: Thu, 22 Aug 2019 15:12:44 +0200 Subject: [PATCH] Fortinet's new module for fortios_system_zone (#61041) --- .../network/fortios/fortios_system_zone.py | 379 ++++++++++++++++++ .../fortios/test_fortios_system_zone.py | 209 ++++++++++ 2 files changed, 588 insertions(+) create mode 100644 lib/ansible/modules/network/fortios/fortios_system_zone.py create mode 100644 test/units/modules/network/fortios/test_fortios_system_zone.py diff --git a/lib/ansible/modules/network/fortios/fortios_system_zone.py b/lib/ansible/modules/network/fortios/fortios_system_zone.py new file mode 100644 index 00000000000..f2c1432fe4f --- /dev/null +++ b/lib/ansible/modules/network/fortios/fortios_system_zone.py @@ -0,0 +1,379 @@ +#!/usr/bin/python +from __future__ import (absolute_import, division, print_function) +# Copyright 2019 Fortinet, Inc. +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +__metaclass__ = type + +ANSIBLE_METADATA = {'status': ['preview'], + 'supported_by': 'community', + 'metadata_version': '1.1'} + +DOCUMENTATION = ''' +--- +module: fortios_system_zone +short_description: Configure zones to group two or more interfaces. When a zone is created you can configure policies for the zone instead of individual + interfaces in the zone in Fortinet's FortiOS and FortiGate. +description: + - This module is able to configure a FortiGate or FortiOS (FOS) device by allowing the + user to set and modify system feature and zone category. + Examples include all parameters and values need to be adjusted to datasources before usage. + Tested with FOS v6.0.5 +version_added: "2.9" +author: + - Miguel Angel Munoz (@mamunozgonzalez) + - Nicolas Thomas (@thomnico) +notes: + - Requires fortiosapi library developed by Fortinet + - Run as a local_action in your playbook +requirements: + - fortiosapi>=0.9.8 +options: + host: + description: + - FortiOS or FortiGate IP address. + type: str + required: false + username: + description: + - FortiOS or FortiGate username. + type: str + required: false + password: + description: + - FortiOS or FortiGate password. + type: str + default: "" + vdom: + description: + - Virtual domain, among those defined previously. A vdom is a + virtual instance of the FortiGate that can be configured and + used as a different unit. + type: str + default: root + https: + description: + - Indicates if the requests towards FortiGate must use HTTPS protocol. + type: bool + default: true + ssl_verify: + description: + - Ensures FortiGate certificate must be verified by a proper CA. + type: bool + default: true + state: + description: + - Indicates whether to create or remove the object. + type: str + required: true + choices: + - present + - absent + system_zone: + description: + - Configure zones to group two or more interfaces. When a zone is created you can configure policies for the zone instead of individual interfaces + in the zone. + default: null + type: dict + suboptions: + interface: + description: + - Add interfaces to this zone. Interfaces must not be assigned to another zone or have firewall policies defined. + type: list + suboptions: + interface_name: + description: + - Select two or more interfaces to add to the zone. Source system.interface.name. + type: str + intrazone: + description: + - Allow or deny traffic routing between different interfaces in the same zone . + type: str + choices: + - allow + - deny + name: + description: + - Zone name. + required: true + type: str + tagging: + description: + - Config object tagging. + type: list + suboptions: + category: + description: + - Tag category. Source system.object-tagging.category. + type: str + name: + description: + - Tagging entry name. + required: true + type: str + tags: + description: + - Tags. + type: list + suboptions: + name: + description: + - Tag name. Source system.object-tagging.tags.name. + required: true + type: str +''' + +EXAMPLES = ''' +- hosts: localhost + vars: + host: "192.168.122.40" + username: "admin" + password: "" + vdom: "root" + ssl_verify: "False" + tasks: + - name: Configure zones to group two or more interfaces. When a zone is created you can configure policies for the zone instead of individual interfaces in + the zone. + fortios_system_zone: + host: "{{ host }}" + username: "{{ username }}" + password: "{{ password }}" + vdom: "{{ vdom }}" + https: "False" + state: "present" + system_zone: + interface: + - + interface_name: " (source system.interface.name)" + intrazone: "allow" + name: "default_name_6" + tagging: + - + category: " (source system.object-tagging.category)" + name: "default_name_9" + tags: + - + name: "default_name_11 (source system.object-tagging.tags.name)" +''' + +RETURN = ''' +build: + description: Build number of the fortigate image + returned: always + type: str + sample: '1547' +http_method: + description: Last method used to provision the content into FortiGate + returned: always + type: str + sample: 'PUT' +http_status: + description: Last result given by FortiGate on last operation applied + returned: always + type: str + sample: "200" +mkey: + description: Master key (id) used in the last call to FortiGate + returned: success + type: str + sample: "id" +name: + description: Name of the table used to fulfill the request + returned: always + type: str + sample: "urlfilter" +path: + description: Path of the table used to fulfill the request + returned: always + type: str + sample: "webfilter" +revision: + description: Internal revision number + returned: always + type: str + sample: "17.0.2.10658" +serial: + description: Serial number of the unit + returned: always + type: str + sample: "FGVMEVYYQT3AB5352" +status: + description: Indication of the operation's result + returned: always + type: str + sample: "success" +vdom: + description: Virtual domain used + returned: always + type: str + sample: "root" +version: + description: Version of the FortiGate + returned: always + type: str + sample: "v5.6.3" + +''' + +from ansible.module_utils.basic import AnsibleModule +from ansible.module_utils.connection import Connection +from ansible.module_utils.network.fortios.fortios import FortiOSHandler +from ansible.module_utils.network.fortimanager.common import FAIL_SOCKET_MSG + + +def login(data, fos): + host = data['host'] + username = data['username'] + password = data['password'] + ssl_verify = data['ssl_verify'] + + fos.debug('on') + if 'https' in data and not data['https']: + fos.https('off') + else: + fos.https('on') + + fos.login(host, username, password, verify=ssl_verify) + + +def filter_system_zone_data(json): + option_list = ['interface', 'intrazone', 'name', + 'tagging'] + dictionary = {} + + for attribute in option_list: + if attribute in json and json[attribute] is not None: + dictionary[attribute] = json[attribute] + + return dictionary + + +def underscore_to_hyphen(data): + if isinstance(data, list): + for elem in data: + elem = underscore_to_hyphen(elem) + elif isinstance(data, dict): + new_data = {} + for k, v in data.items(): + new_data[k.replace('_', '-')] = underscore_to_hyphen(v) + data = new_data + + return data + + +def system_zone(data, fos): + vdom = data['vdom'] + state = data['state'] + system_zone_data = data['system_zone'] + filtered_data = underscore_to_hyphen(filter_system_zone_data(system_zone_data)) + + if state == "present": + return fos.set('system', + 'zone', + data=filtered_data, + vdom=vdom) + + elif state == "absent": + return fos.delete('system', + 'zone', + mkey=filtered_data['name'], + vdom=vdom) + + +def is_successful_status(status): + return status['status'] == "success" or \ + status['http_method'] == "DELETE" and status['http_status'] == 404 + + +def fortios_system(data, fos): + + if data['system_zone']: + resp = system_zone(data, fos) + + return not is_successful_status(resp), \ + resp['status'] == "success", \ + resp + + +def main(): + fields = { + "host": {"required": False, "type": "str"}, + "username": {"required": False, "type": "str"}, + "password": {"required": False, "type": "str", "default": "", "no_log": True}, + "vdom": {"required": False, "type": "str", "default": "root"}, + "https": {"required": False, "type": "bool", "default": True}, + "ssl_verify": {"required": False, "type": "bool", "default": True}, + "state": {"required": True, "type": "str", + "choices": ["present", "absent"]}, + "system_zone": { + "required": False, "type": "dict", "default": None, + "options": { + "interface": {"required": False, "type": "list", + "options": { + "interface_name": {"required": False, "type": "str"} + }}, + "intrazone": {"required": False, "type": "str", + "choices": ["allow", "deny"]}, + "name": {"required": True, "type": "str"}, + "tagging": {"required": False, "type": "list", + "options": { + "category": {"required": False, "type": "str"}, + "name": {"required": True, "type": "str"}, + "tags": {"required": False, "type": "list", + "options": { + "name": {"required": True, "type": "str"} + }} + }} + + } + } + } + + module = AnsibleModule(argument_spec=fields, + supports_check_mode=False) + + # legacy_mode refers to using fortiosapi instead of HTTPAPI + legacy_mode = 'host' in module.params and module.params['host'] is not None and \ + 'username' in module.params and module.params['username'] is not None and \ + 'password' in module.params and module.params['password'] is not None + + if not legacy_mode: + if module._socket_path: + connection = Connection(module._socket_path) + fos = FortiOSHandler(connection) + + is_error, has_changed, result = fortios_system(module.params, fos) + else: + module.fail_json(**FAIL_SOCKET_MSG) + else: + try: + from fortiosapi import FortiOSAPI + except ImportError: + module.fail_json(msg="fortiosapi module is required") + + fos = FortiOSAPI() + + login(module.params, fos) + is_error, has_changed, result = fortios_system(module.params, fos) + fos.logout() + + if not is_error: + module.exit_json(changed=has_changed, meta=result) + else: + module.fail_json(msg="Error in repo", meta=result) + + +if __name__ == '__main__': + main() diff --git a/test/units/modules/network/fortios/test_fortios_system_zone.py b/test/units/modules/network/fortios/test_fortios_system_zone.py new file mode 100644 index 00000000000..b56546dcc71 --- /dev/null +++ b/test/units/modules/network/fortios/test_fortios_system_zone.py @@ -0,0 +1,209 @@ +# Copyright 2019 Fortinet, Inc. +# +# This program is free software: you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation, either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with Ansible. If not, see . + +# Make coding more python3-ish +from __future__ import (absolute_import, division, print_function) +__metaclass__ = type + +import os +import json +import pytest +from mock import ANY +from ansible.module_utils.network.fortios.fortios import FortiOSHandler + +try: + from ansible.modules.network.fortios import fortios_system_zone +except ImportError: + pytest.skip("Could not load required modules for testing", allow_module_level=True) + + +@pytest.fixture(autouse=True) +def connection_mock(mocker): + connection_class_mock = mocker.patch('ansible.modules.network.fortios.fortios_system_zone.Connection') + return connection_class_mock + + +fos_instance = FortiOSHandler(connection_mock) + + +def test_system_zone_creation(mocker): + schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema') + + set_method_result = {'status': 'success', 'http_method': 'POST', 'http_status': 200} + set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result) + + input_data = { + 'username': 'admin', + 'state': 'present', + 'system_zone': {'intrazone': 'allow', + 'name': 'default_name_4', + + }, + 'vdom': 'root'} + + is_error, changed, response = fortios_system_zone.fortios_system(input_data, fos_instance) + + expected_data = {'intrazone': 'allow', + 'name': 'default_name_4', + + } + + set_method_mock.assert_called_with('system', 'zone', data=expected_data, vdom='root') + schema_method_mock.assert_not_called() + assert not is_error + assert changed + assert response['status'] == 'success' + assert response['http_status'] == 200 + + +def test_system_zone_creation_fails(mocker): + schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema') + + set_method_result = {'status': 'error', 'http_method': 'POST', 'http_status': 500} + set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result) + + input_data = { + 'username': 'admin', + 'state': 'present', + 'system_zone': {'intrazone': 'allow', + 'name': 'default_name_4', + + }, + 'vdom': 'root'} + + is_error, changed, response = fortios_system_zone.fortios_system(input_data, fos_instance) + + expected_data = {'intrazone': 'allow', + 'name': 'default_name_4', + + } + + set_method_mock.assert_called_with('system', 'zone', data=expected_data, vdom='root') + schema_method_mock.assert_not_called() + assert is_error + assert not changed + assert response['status'] == 'error' + assert response['http_status'] == 500 + + +def test_system_zone_removal(mocker): + schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema') + + delete_method_result = {'status': 'success', 'http_method': 'POST', 'http_status': 200} + delete_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.delete', return_value=delete_method_result) + + input_data = { + 'username': 'admin', + 'state': 'absent', + 'system_zone': {'intrazone': 'allow', + 'name': 'default_name_4', + + }, + 'vdom': 'root'} + + is_error, changed, response = fortios_system_zone.fortios_system(input_data, fos_instance) + + delete_method_mock.assert_called_with('system', 'zone', mkey=ANY, vdom='root') + schema_method_mock.assert_not_called() + assert not is_error + assert changed + assert response['status'] == 'success' + assert response['http_status'] == 200 + + +def test_system_zone_deletion_fails(mocker): + schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema') + + delete_method_result = {'status': 'error', 'http_method': 'POST', 'http_status': 500} + delete_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.delete', return_value=delete_method_result) + + input_data = { + 'username': 'admin', + 'state': 'absent', + 'system_zone': {'intrazone': 'allow', + 'name': 'default_name_4', + + }, + 'vdom': 'root'} + + is_error, changed, response = fortios_system_zone.fortios_system(input_data, fos_instance) + + delete_method_mock.assert_called_with('system', 'zone', mkey=ANY, vdom='root') + schema_method_mock.assert_not_called() + assert is_error + assert not changed + assert response['status'] == 'error' + assert response['http_status'] == 500 + + +def test_system_zone_idempotent(mocker): + schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema') + + set_method_result = {'status': 'error', 'http_method': 'DELETE', 'http_status': 404} + set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result) + + input_data = { + 'username': 'admin', + 'state': 'present', + 'system_zone': {'intrazone': 'allow', + 'name': 'default_name_4', + + }, + 'vdom': 'root'} + + is_error, changed, response = fortios_system_zone.fortios_system(input_data, fos_instance) + + expected_data = {'intrazone': 'allow', + 'name': 'default_name_4', + + } + + set_method_mock.assert_called_with('system', 'zone', data=expected_data, vdom='root') + schema_method_mock.assert_not_called() + assert not is_error + assert not changed + assert response['status'] == 'error' + assert response['http_status'] == 404 + + +def test_system_zone_filter_foreign_attributes(mocker): + schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema') + + set_method_result = {'status': 'success', 'http_method': 'POST', 'http_status': 200} + set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result) + + input_data = { + 'username': 'admin', + 'state': 'present', + 'system_zone': { + 'random_attribute_not_valid': 'tag', 'intrazone': 'allow', + 'name': 'default_name_4', + + }, + 'vdom': 'root'} + + is_error, changed, response = fortios_system_zone.fortios_system(input_data, fos_instance) + + expected_data = {'intrazone': 'allow', + 'name': 'default_name_4', + + } + + set_method_mock.assert_called_with('system', 'zone', data=expected_data, vdom='root') + schema_method_mock.assert_not_called() + assert not is_error + assert changed + assert response['status'] == 'success' + assert response['http_status'] == 200