From 9edf64eaeb2d4356612a601dc74883698a060af9 Mon Sep 17 00:00:00 2001 From: Brian Coca Date: Thu, 21 Sep 2023 15:47:53 -0400 Subject: [PATCH] Deprecating paramiko options in base config (#81593) * Deprecating paramiko options in base config they exist in the plugin itself since 2.14 * clog --- changelogs/fragments/paramiko_globals.yml | 3 +++ lib/ansible/config/base.yml | 9 ++++++++- 2 files changed, 11 insertions(+), 1 deletion(-) create mode 100644 changelogs/fragments/paramiko_globals.yml diff --git a/changelogs/fragments/paramiko_globals.yml b/changelogs/fragments/paramiko_globals.yml new file mode 100644 index 00000000000..1a3b1da3a27 --- /dev/null +++ b/changelogs/fragments/paramiko_globals.yml @@ -0,0 +1,3 @@ +deprecated_features: + - paramiko connection plugin, configuration items in the global scope are being deprecated and will be removed in favor or the existing same options in the plugin itself. + Users should not need to change anything (how to configure them are the same) but plugin authors using the global constants should move to using the plugin's get_option(). diff --git a/lib/ansible/config/base.yml b/lib/ansible/config/base.yml index 3b795553eb9..bf1f56b502e 100644 --- a/lib/ansible/config/base.yml +++ b/lib/ansible/config/base.yml @@ -1793,13 +1793,16 @@ PAGER: version_added: '2.15' - name: PAGER PARAMIKO_HOST_KEY_AUTO_ADD: - # TODO: move to plugin default: False description: 'TODO: write it' env: [{name: ANSIBLE_PARAMIKO_HOST_KEY_AUTO_ADD}] ini: - {key: host_key_auto_add, section: paramiko_connection} type: boolean + deprecated: + why: This option was moved to the plugin itself + version: "2.20" + alternatives: Use the option from the plugin itself. PARAMIKO_LOOK_FOR_KEYS: name: look for keys default: True @@ -1808,6 +1811,10 @@ PARAMIKO_LOOK_FOR_KEYS: ini: - {key: look_for_keys, section: paramiko_connection} type: boolean + deprecated: + why: This option was moved to the plugin itself + version: "2.20" + alternatives: Use the option from the plugin itself. PERSISTENT_CONTROL_PATH_DIR: name: Persistence socket path default: '{{ ANSIBLE_HOME ~ "/pc" }}'