From 9dceca8a88eaafaa5ca55619ca9ba71dc11ee760 Mon Sep 17 00:00:00 2001 From: Chris Archibald Date: Tue, 14 Aug 2018 09:39:52 -0700 Subject: [PATCH] Deprecated Old NetApp Cdot Modules (#43781) * MVP2 Post ElementSW OSRB sync * Revert "MVP2 Post ElementSW OSRB sync" This reverts commit c13db2ad962cd56bffce052c2891c558a2240c72. Undoing bad push * move deprecated files * add documentation * add new line * Fix version issue * fix issue with ignore file, hopefully * Add ontap modules to porting guide * fix refs * add _module to ref --- .../docsite/rst/porting_guides/porting_guide_2.7.rst | 12 ++++++++++-- .../{na_cdot_aggregate.py => _na_cdot_aggregate.py} | 7 ++++++- .../{na_cdot_license.py => _na_cdot_license.py} | 7 ++++++- .../netapp/{na_cdot_lun.py => _na_cdot_lun.py} | 7 ++++++- .../netapp/{na_cdot_qtree.py => _na_cdot_qtree.py} | 7 ++++++- .../netapp/{na_cdot_svm.py => _na_cdot_svm.py} | 7 ++++++- .../netapp/{na_cdot_user.py => _na_cdot_user.py} | 7 ++++++- .../{na_cdot_user_role.py => _na_cdot_user_role.py} | 7 ++++++- .../netapp/{na_cdot_volume.py => _na_cdot_volume.py} | 7 ++++++- test/sanity/validate-modules/ignore.txt | 12 ++++++------ 10 files changed, 64 insertions(+), 16 deletions(-) rename lib/ansible/modules/storage/netapp/{na_cdot_aggregate.py => _na_cdot_aggregate.py} (97%) rename lib/ansible/modules/storage/netapp/{na_cdot_license.py => _na_cdot_license.py} (97%) rename lib/ansible/modules/storage/netapp/{na_cdot_lun.py => _na_cdot_lun.py} (98%) rename lib/ansible/modules/storage/netapp/{na_cdot_qtree.py => _na_cdot_qtree.py} (97%) rename lib/ansible/modules/storage/netapp/{na_cdot_svm.py => _na_cdot_svm.py} (97%) rename lib/ansible/modules/storage/netapp/{na_cdot_user.py => _na_cdot_user.py} (98%) rename lib/ansible/modules/storage/netapp/{na_cdot_user_role.py => _na_cdot_user_role.py} (97%) rename lib/ansible/modules/storage/netapp/{na_cdot_volume.py => _na_cdot_volume.py} (98%) diff --git a/docs/docsite/rst/porting_guides/porting_guide_2.7.rst b/docs/docsite/rst/porting_guides/porting_guide_2.7.rst index 0ed3516b424..4ea30af876f 100644 --- a/docs/docsite/rst/porting_guides/porting_guide_2.7.rst +++ b/docs/docsite/rst/porting_guides/porting_guide_2.7.rst @@ -136,8 +136,16 @@ The following modules no longer exist: Deprecation notices ------------------- -The following modules will be removed in Ansible 2.10. Please update your playbooks accordingly. - +The following modules will be removed in Ansible 2.11. Please update your playbooks accordingly. + +* ``na_cdot_aggregate`` use :ref:`na_ontap_aggregate ` instead. +* ``na_cdot_license`` use :ref:`na_ontap_license ` instead. +* ``na_cdot_lun`` use :ref:`na_ontap_lun ` instead. +* ``na_cdot_qtree`` use :ref:`na_ontap_qtree ` instead. +* ``na_cdot_svm`` use :ref:`na_ontap_svm ` instead. +* ``na_cdot_user`` use :ref:`na_ontap_user ` instead. +* ``na_cdot_user_role`` use :ref:`na_ontap_user_role ` instead. +* ``na_cdot_volume`` use :ref:`na_ontap_volume ` instead. Noteworthy module changes ------------------------- diff --git a/lib/ansible/modules/storage/netapp/na_cdot_aggregate.py b/lib/ansible/modules/storage/netapp/_na_cdot_aggregate.py similarity index 97% rename from lib/ansible/modules/storage/netapp/na_cdot_aggregate.py rename to lib/ansible/modules/storage/netapp/_na_cdot_aggregate.py index 7bf51dda2a5..bfd04c4d079 100644 --- a/lib/ansible/modules/storage/netapp/na_cdot_aggregate.py +++ b/lib/ansible/modules/storage/netapp/_na_cdot_aggregate.py @@ -8,7 +8,7 @@ __metaclass__ = type ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} @@ -22,6 +22,11 @@ extends_documentation_fragment: version_added: '2.3' author: Sumit Kumar (sumit4@netapp.com) +deprecated: + removed_in: '2.11' + why: Updated modules released with increased functionality + alternative: Use M(na_ontap_aggregate) instead. + description: - Create or destroy aggregates on NetApp cDOT. diff --git a/lib/ansible/modules/storage/netapp/na_cdot_license.py b/lib/ansible/modules/storage/netapp/_na_cdot_license.py similarity index 97% rename from lib/ansible/modules/storage/netapp/na_cdot_license.py rename to lib/ansible/modules/storage/netapp/_na_cdot_license.py index 82a16b0a046..00513d3c62f 100644 --- a/lib/ansible/modules/storage/netapp/na_cdot_license.py +++ b/lib/ansible/modules/storage/netapp/_na_cdot_license.py @@ -8,7 +8,7 @@ __metaclass__ = type ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} @@ -22,6 +22,11 @@ extends_documentation_fragment: version_added: '2.3' author: Sumit Kumar (sumit4@netapp.com) +deprecated: + removed_in: '2.11' + why: Updated modules released with increased functionality + alternative: Use M(na_ontap_license) instead. + description: - Add or remove licenses on NetApp ONTAP. diff --git a/lib/ansible/modules/storage/netapp/na_cdot_lun.py b/lib/ansible/modules/storage/netapp/_na_cdot_lun.py similarity index 98% rename from lib/ansible/modules/storage/netapp/na_cdot_lun.py rename to lib/ansible/modules/storage/netapp/_na_cdot_lun.py index 5304c8e7d9b..04524050414 100644 --- a/lib/ansible/modules/storage/netapp/na_cdot_lun.py +++ b/lib/ansible/modules/storage/netapp/_na_cdot_lun.py @@ -8,7 +8,7 @@ __metaclass__ = type ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} @@ -22,6 +22,11 @@ extends_documentation_fragment: version_added: '2.3' author: Sumit Kumar (sumit4@netapp.com) +deprecated: + removed_in: '2.11' + why: Updated modules released with increased functionality + alternative: Use M(na_ontap_lun) instead. + description: - Create, destroy, resize luns on NetApp cDOT. diff --git a/lib/ansible/modules/storage/netapp/na_cdot_qtree.py b/lib/ansible/modules/storage/netapp/_na_cdot_qtree.py similarity index 97% rename from lib/ansible/modules/storage/netapp/na_cdot_qtree.py rename to lib/ansible/modules/storage/netapp/_na_cdot_qtree.py index 0119327d8c1..85987857249 100644 --- a/lib/ansible/modules/storage/netapp/na_cdot_qtree.py +++ b/lib/ansible/modules/storage/netapp/_na_cdot_qtree.py @@ -8,7 +8,7 @@ __metaclass__ = type ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} @@ -22,6 +22,11 @@ extends_documentation_fragment: version_added: '2.3' author: Sumit Kumar (sumit4@netapp.com) +deprecated: + removed_in: '2.11' + why: Updated modules released with increased functionality + alternative: Use M(na_ontap_qtree) instead. + description: - Create or destroy Qtrees. diff --git a/lib/ansible/modules/storage/netapp/na_cdot_svm.py b/lib/ansible/modules/storage/netapp/_na_cdot_svm.py similarity index 97% rename from lib/ansible/modules/storage/netapp/na_cdot_svm.py rename to lib/ansible/modules/storage/netapp/_na_cdot_svm.py index 6f9b38ae7e2..1ba565bdbac 100644 --- a/lib/ansible/modules/storage/netapp/na_cdot_svm.py +++ b/lib/ansible/modules/storage/netapp/_na_cdot_svm.py @@ -8,7 +8,7 @@ __metaclass__ = type ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} @@ -22,6 +22,11 @@ extends_documentation_fragment: version_added: '2.3' author: Sumit Kumar (sumit4@netapp.com) +deprecated: + removed_in: '2.11' + why: Updated modules released with increased functionality + alternative: Use M(na_ontap_svm) instead. + description: - Create or destroy svm on NetApp cDOT diff --git a/lib/ansible/modules/storage/netapp/na_cdot_user.py b/lib/ansible/modules/storage/netapp/_na_cdot_user.py similarity index 98% rename from lib/ansible/modules/storage/netapp/na_cdot_user.py rename to lib/ansible/modules/storage/netapp/_na_cdot_user.py index bbfe002811d..9f03f7e95e0 100644 --- a/lib/ansible/modules/storage/netapp/na_cdot_user.py +++ b/lib/ansible/modules/storage/netapp/_na_cdot_user.py @@ -8,7 +8,7 @@ __metaclass__ = type ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} @@ -22,6 +22,11 @@ extends_documentation_fragment: version_added: '2.3' author: Sumit Kumar (sumit4@netapp.com) +deprecated: + removed_in: '2.11' + why: Updated modules released with increased functionality + alternative: Use M(na_ontap_user) instead. + description: - Create or destroy users. diff --git a/lib/ansible/modules/storage/netapp/na_cdot_user_role.py b/lib/ansible/modules/storage/netapp/_na_cdot_user_role.py similarity index 97% rename from lib/ansible/modules/storage/netapp/na_cdot_user_role.py rename to lib/ansible/modules/storage/netapp/_na_cdot_user_role.py index 93bef8d95c8..c03a910242b 100644 --- a/lib/ansible/modules/storage/netapp/na_cdot_user_role.py +++ b/lib/ansible/modules/storage/netapp/_na_cdot_user_role.py @@ -8,7 +8,7 @@ __metaclass__ = type ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} @@ -22,6 +22,11 @@ extends_documentation_fragment: version_added: '2.3' author: Sumit Kumar (sumit4@netapp.com) +deprecated: + removed_in: '2.11' + why: Updated modules released with increased functionality + alternative: Use M(na_ontap_user_role) instead. + description: - Create or destroy user roles diff --git a/lib/ansible/modules/storage/netapp/na_cdot_volume.py b/lib/ansible/modules/storage/netapp/_na_cdot_volume.py similarity index 98% rename from lib/ansible/modules/storage/netapp/na_cdot_volume.py rename to lib/ansible/modules/storage/netapp/_na_cdot_volume.py index 337303b3afc..0db2a053b2f 100644 --- a/lib/ansible/modules/storage/netapp/na_cdot_volume.py +++ b/lib/ansible/modules/storage/netapp/_na_cdot_volume.py @@ -8,7 +8,7 @@ __metaclass__ = type ANSIBLE_METADATA = {'metadata_version': '1.1', - 'status': ['preview'], + 'status': ['deprecated'], 'supported_by': 'community'} @@ -22,6 +22,11 @@ extends_documentation_fragment: version_added: '2.3' author: Sumit Kumar (sumit4@netapp.com) +deprecated: + removed_in: '2.11' + why: Updated modules released with increased functionality + alternative: Use M(na_ontap_volume) instead. + description: - Create or destroy volumes on NetApp cDOT diff --git a/test/sanity/validate-modules/ignore.txt b/test/sanity/validate-modules/ignore.txt index 64c2ad96503..aafe0da1cf8 100644 --- a/test/sanity/validate-modules/ignore.txt +++ b/test/sanity/validate-modules/ignore.txt @@ -1077,12 +1077,12 @@ lib/ansible/modules/source_control/subversion.py E322 lib/ansible/modules/storage/infinidat/infini_export.py E323 lib/ansible/modules/storage/infinidat/infini_export.py E324 lib/ansible/modules/storage/infinidat/infini_export_client.py E323 -lib/ansible/modules/storage/netapp/na_cdot_license.py E329 -lib/ansible/modules/storage/netapp/na_cdot_lun.py E325 -lib/ansible/modules/storage/netapp/na_cdot_volume.py E317 -lib/ansible/modules/storage/netapp/na_cdot_volume.py E322 -lib/ansible/modules/storage/netapp/na_cdot_volume.py E324 -lib/ansible/modules/storage/netapp/na_cdot_volume.py E325 +lib/ansible/modules/storage/netapp/_na_cdot_license.py E329 +lib/ansible/modules/storage/netapp/_na_cdot_lun.py E325 +lib/ansible/modules/storage/netapp/_na_cdot_volume.py E317 +lib/ansible/modules/storage/netapp/_na_cdot_volume.py E322 +lib/ansible/modules/storage/netapp/_na_cdot_volume.py E324 +lib/ansible/modules/storage/netapp/_na_cdot_volume.py E325 lib/ansible/modules/storage/netapp/netapp_e_amg.py E322 lib/ansible/modules/storage/netapp/netapp_e_amg.py E325 lib/ansible/modules/storage/netapp/netapp_e_amg_role.py E322