Merge pull request #1411 from resmo/fix/stable-2.0/case_insensivity

[stable-2.0] cloudstack: fix name is not case insensitive
reviewable/pr18780/r1
Toshio Kuratomi 9 years ago
commit 9bae6eafee

@ -145,19 +145,16 @@ class AnsibleCloudStackAffinityGroup(AnsibleCloudStack):
def get_affinity_group(self):
if not self.affinity_group:
affinity_group = self.module.params.get('name')
args = {}
args['projectid'] = self.get_project(key='id')
args['account'] = self.get_account('name')
args['domainid'] = self.get_domain('id')
args['name'] = self.module.params.get('name')
affinity_groups = self.cs.listAffinityGroups(**args)
if affinity_groups:
for a in affinity_groups['affinitygroup']:
if affinity_group in [ a['name'], a['id'] ]:
self.affinity_group = a
break
self.affinity_group = affinity_groups['affinitygroup'][0]
return self.affinity_group

@ -42,6 +42,16 @@ options:
required: false
default: 'present'
choices: [ 'present', 'absent' ]
domain:
description:
- Domain the security group is related to.
required: false
default: null
account:
description:
- Account the security group is related to.
required: false
default: null
project:
description:
- Name of the project the security group to be created in.
@ -81,6 +91,26 @@ description:
returned: success
type: string
sample: application security group
tags:
description: List of resource tags associated with the security group.
returned: success
type: dict
sample: '[ { "key": "foo", "value": "bar" } ]'
project:
description: Name of project the security group is related to.
returned: success
type: string
sample: Production
domain:
description: Domain the security group is related to.
returned: success
type: string
sample: example domain
account:
description: Account the security group is related to.
returned: success
type: string
sample: example account
'''
try:
@ -102,15 +132,16 @@ class AnsibleCloudStackSecurityGroup(AnsibleCloudStack):
def get_security_group(self):
if not self.security_group:
sg_name = self.module.params.get('name')
args = {}
args['projectid'] = self.get_project('id')
args['projectid'] = self.get_project(key='id')
args['account'] = self.get_account(key='name')
args['domainid'] = self.get_domain(key='id')
args['securitygroupname'] = self.module.params.get('name')
sgs = self.cs.listSecurityGroups(**args)
if sgs:
for s in sgs['securitygroup']:
if s['name'] == sg_name:
self.security_group = s
break
self.security_group = sgs['securitygroup'][0]
return self.security_group
@ -121,7 +152,9 @@ class AnsibleCloudStackSecurityGroup(AnsibleCloudStack):
args = {}
args['name'] = self.module.params.get('name')
args['projectid'] = self.get_project('id')
args['projectid'] = self.get_project(key='id')
args['account'] = self.get_account(key='name')
args['domainid'] = self.get_domain(key='id')
args['description'] = self.module.params.get('description')
if not self.module.check_mode:
@ -140,7 +173,9 @@ class AnsibleCloudStackSecurityGroup(AnsibleCloudStack):
args = {}
args['name'] = self.module.params.get('name')
args['projectid'] = self.get_project('id')
args['projectid'] = self.get_project(key='id')
args['account'] = self.get_account(key='name')
args['domainid'] = self.get_domain(key='id')
if not self.module.check_mode:
res = self.cs.deleteSecurityGroup(**args)
@ -158,6 +193,8 @@ def main():
description = dict(default=None),
state = dict(choices=['present', 'absent'], default='present'),
project = dict(default=None),
account = dict(default=None),
domain = dict(default=None),
))
module = AnsibleModule(

Loading…
Cancel
Save