From 9268aa0289349a17027290e8701ecbfcbdd2fbc6 Mon Sep 17 00:00:00 2001 From: Dag Wieers Date: Tue, 30 Oct 2012 10:36:11 +0100 Subject: [PATCH] Use return codes > 255 for Ansible-specific errors. I had made and pushed this change after you already pulled the request. @dhozac indicated that it would probably be better to use return codes > 255 for anything related to Ansible itself. Which makes sens :) --- library/command | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/library/command b/library/command index 63f7cdc70b3..e1b5d0c240c 100755 --- a/library/command +++ b/library/command @@ -84,7 +84,7 @@ def main(): args = module.params['args'] if args.strip() == '': - module.fail_json(rc=255, msg="no command given") + module.fail_json(rc=256, msg="no command given") if chdir: os.chdir(os.path.expanduser(chdir)) @@ -99,7 +99,7 @@ def main(): except (OSError, IOError), e: module.fail_json(rc=e.errno, msg=str(e), cmd=args) except: - module.fail_json(rc=254, msg=traceback.format_exc(), cmd=args) + module.fail_json(rc=257, msg=traceback.format_exc(), cmd=args) endd = datetime.datetime.now() delta = endd - startd @@ -178,9 +178,9 @@ class CommandModule(AnsibleModule): elif m.group(2) == "chdir": v = os.path.expanduser(v) if not (os.path.exists(v) and os.path.isdir(v)): - self.fail_json(rc=253, msg="cannot change to directory '%s': path does not exist" % v) + self.fail_json(rc=258, msg="cannot change to directory '%s': path does not exist" % v) elif v[0] != '/': - self.fail_json(rc=252, msg="the path for 'chdir' argument must be fully qualified") + self.fail_json(rc=259, msg="the path for 'chdir' argument must be fully qualified") params['chdir'] = v args = r.sub("", args) params['args'] = args