From 84527b1d3135cdc16d6fc90cc3c11992d80433bc Mon Sep 17 00:00:00 2001 From: Michael DeHaan Date: Mon, 18 Mar 2013 00:40:57 -0400 Subject: [PATCH] Add type casting to user/group modules, remove executable bit from other modules --- group | 8 ++++---- lvol | 0 pkgin | 0 user | 28 ++++++++++++++-------------- 4 files changed, 18 insertions(+), 18 deletions(-) mode change 100755 => 100644 lvol mode change 100755 => 100644 pkgin diff --git a/group b/group index 03ae1438dab..7feb35161f2 100644 --- a/group +++ b/group @@ -213,10 +213,10 @@ class AIX(Group): def main(): module = AnsibleModule( argument_spec = dict( - state=dict(default='present', choices=['present', 'absent']), - name=dict(required=True), - gid=dict(default=None), - system=dict(default='no', choices=['yes', 'no']), + state=dict(default='present', choices=['present', 'absent'], type='str'), + name=dict(required=True, type='str'), + gid=dict(default=None, type='str'), + system=dict(default='no', choices=['yes', 'no'], type='bool'), ), supports_check_mode=True ) diff --git a/lvol b/lvol old mode 100755 new mode 100644 diff --git a/pkgin b/pkgin old mode 100755 new mode 100644 diff --git a/user b/user index a297019cd01..7a30b42c91f 100644 --- a/user +++ b/user @@ -992,15 +992,15 @@ def main(): } module = AnsibleModule( argument_spec = dict( - state=dict(default='present', choices=['present', 'absent']), - name=dict(required=True, aliases=['user']), - uid=dict(default=None), - group=dict(default=None), - groups=dict(default=None), - comment=dict(default=None), - home=dict(default=None), - shell=dict(default=None), - password=dict(default=None), + state=dict(default='present', choices=['present', 'absent'], type='str'), + name=dict(required=True, aliases=['user'], type='str'), + uid=dict(default=None, type='str'), + group=dict(default=None, type='str'), + groups=dict(default=None, type='str'), + comment=dict(default=None, type='str'), + home=dict(default=None, type='str'), + shell=dict(default=None, type='str'), + password=dict(default=None, type='str'), # following options are specific to userdel force=dict(default='no', type='bool'), remove=dict(default='no', type='bool'), @@ -1011,11 +1011,11 @@ def main(): append=dict(default='no', type='bool'), # following are specific to ssh key generation generate_ssh_key=dict(choices=BOOLEANS, type='bool'), - ssh_key_bits=dict(default=ssh_defaults['bits']), - ssh_key_type=dict(default=ssh_defaults['type']), - ssh_key_file=dict(default=None), - ssh_key_comment=dict(default=ssh_defaults['comment']), - ssh_key_passphrase=dict(default=None) + ssh_key_bits=dict(default=ssh_defaults['bits'], type='str'), + ssh_key_type=dict(default=ssh_defaults['type'], type='str'), + ssh_key_file=dict(default=None, type='str'), + ssh_key_comment=dict(default=ssh_defaults['comment'], type='str'), + ssh_key_passphrase=dict(default=None, type='str') ), supports_check_mode=True )