From 7dbdc8a92e70bc472b50d2bb64989d439b382588 Mon Sep 17 00:00:00 2001 From: sevs44936 Date: Wed, 18 Jul 2018 06:13:16 +0200 Subject: [PATCH] Fix for cloudflare_dns SRV record and Python3 (#42914) This fix adds correct way of comparing dict with dict while managing cloudflare_dns SRV record. Fixes: #40445 --- lib/ansible/modules/net_tools/cloudflare_dns.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ansible/modules/net_tools/cloudflare_dns.py b/lib/ansible/modules/net_tools/cloudflare_dns.py index d51f77f4aab..f3fcc1fffe1 100644 --- a/lib/ansible/modules/net_tools/cloudflare_dns.py +++ b/lib/ansible/modules/net_tools/cloudflare_dns.py @@ -558,7 +558,7 @@ class CloudflareAPI(object): if (params['priority'] is not None) and ('priority' in cur_record) and (cur_record['priority'] != params['priority']): do_update = True if ('data' in new_record) and ('data' in cur_record): - if (cur_record['data'] > new_record['data']) - (cur_record['data'] < new_record['data']): + if (cur_record['data'] != new_record['data']): do_update = True if (params['type'] == 'CNAME') and (cur_record['content'] != new_record['content']): do_update = True