From 7b44dd530f8ba8797075cb8876216432ab9e442d Mon Sep 17 00:00:00 2001 From: Brian Coca Date: Wed, 12 Sep 2012 14:47:06 -0400 Subject: [PATCH] small fix to prevent temp file from living past its succesful usage Signed-off-by: Brian Coca --- copy | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/copy b/copy index beda6652ba3..b9506aac12f 100755 --- a/copy +++ b/copy @@ -67,9 +67,9 @@ def main(): backup_file = module.backup_local(dest) #TODO:pid + epoch should avoid most collisions, hostname/mac for those using nfs? # might be an issue with exceeding path length - dest_tmp = "%s.%s.%s.tmp" % (dest,os.getpid(),time.gmtime) + dest_tmp = "%s.%s.%s.tmp" % (dest,os.getpid(),time.gmtime()) shutil.copyfile(src, dest_tmp) - shutil.copyfile(dest_tmp, dest) + shutil.move(dest_tmp, dest) except shutil.Error: module.fail_json(msg="failed to copy: %s and %s are the same" % (src, dest)) except IOError: