mirror of https://github.com/ansible/ansible.git
Backport PR for Check Point Unit tests for the following module from PR 62338 (#62390)
* Network and address range tests (#62338)
* commit network and address_range
* remove test_cp_mgmt_network from ignore.txt
(cherry picked from commit b4dcd7c835)
* changelog
* fix shippable
Signed-off-by: Sumit Jaiswal <sjaiswal@redhat.com>
pull/62433/head
Sumit Jaiswal
5 years ago
committed by
Toshio Kuratomi
parent
99f22c1751
commit
7a668dab06
@ -0,0 +1,5 @@
|
||||
---
|
||||
bugfixes:
|
||||
- "Unit tests for cp_mgmt_network"
|
||||
- "Unit tests for cp_mgmt_address_range"
|
||||
- "Unit tests for cp_mgmt_address_range_facts(https://github.com/ansible/ansible/pull/62338)"
|
||||
@ -0,0 +1,116 @@
|
||||
# Ansible module to manage CheckPoint Firewall (c) 2019
|
||||
#
|
||||
# Ansible is free software: you can redistribute it and/or modify
|
||||
# it under the terms of the GNU General Public License as published by
|
||||
# the Free Software Foundation, either version 3 of the License, or
|
||||
# (at your option) any later version.
|
||||
#
|
||||
# Ansible is distributed in the hope that it will be useful,
|
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
# GNU General Public License for more details.
|
||||
#
|
||||
# You should have received a copy of the GNU General Public License
|
||||
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
|
||||
#
|
||||
|
||||
from __future__ import absolute_import, division, print_function
|
||||
__metaclass__ = type
|
||||
|
||||
import pytest
|
||||
from units.modules.utils import set_module_args, exit_json, fail_json, AnsibleExitJson
|
||||
|
||||
from ansible.module_utils import basic
|
||||
from ansible.modules.network.check_point import cp_mgmt_address_range
|
||||
|
||||
OBJECT = {
|
||||
"name": "New Address Range 1",
|
||||
"ip_address_first": "192.0.2.1",
|
||||
"ip_address_last": "192.0.2.10"
|
||||
}
|
||||
|
||||
CREATE_PAYLOAD = {
|
||||
"name": "New Address Range 1",
|
||||
"ip_address_first": "192.0.2.1",
|
||||
"ip_address_last": "192.0.2.10"
|
||||
}
|
||||
|
||||
UPDATE_PAYLOAD = {
|
||||
"name": "New Address Range 1",
|
||||
"color": "blue",
|
||||
"ip_address_first": "192.0.2.1",
|
||||
"ip_address_last": "192.0.2.1"
|
||||
}
|
||||
|
||||
OBJECT_AFTER_UPDATE = UPDATE_PAYLOAD
|
||||
|
||||
DELETE_PAYLOAD = {
|
||||
"name": "New Address Range 1",
|
||||
"state": "absent"
|
||||
}
|
||||
|
||||
function_path = 'ansible.modules.network.check_point.cp_mgmt_address_range.api_call'
|
||||
api_call_object = 'address-range'
|
||||
|
||||
|
||||
class TestCheckpointAddressRange(object):
|
||||
module = cp_mgmt_address_range
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
def module_mock(self, mocker):
|
||||
return mocker.patch.multiple(basic.AnsibleModule, exit_json=exit_json, fail_json=fail_json)
|
||||
|
||||
@pytest.fixture
|
||||
def connection_mock(self, mocker):
|
||||
connection_class_mock = mocker.patch('ansible.module_utils.network.checkpoint.checkpoint.Connection')
|
||||
return connection_class_mock.return_value
|
||||
|
||||
def test_create(self, mocker, connection_mock):
|
||||
mock_function = mocker.patch(function_path)
|
||||
mock_function.return_value = {'changed': True, api_call_object: OBJECT}
|
||||
result = self._run_module(CREATE_PAYLOAD)
|
||||
|
||||
assert result['changed']
|
||||
assert OBJECT.items() == result[api_call_object].items()
|
||||
|
||||
def test_create_idempotent(self, mocker, connection_mock):
|
||||
mock_function = mocker.patch(function_path)
|
||||
mock_function.return_value = {'changed': False, api_call_object: OBJECT}
|
||||
result = self._run_module(CREATE_PAYLOAD)
|
||||
|
||||
assert not result['changed']
|
||||
|
||||
def test_update(self, mocker, connection_mock):
|
||||
mock_function = mocker.patch(function_path)
|
||||
mock_function.return_value = {'changed': True, api_call_object: OBJECT_AFTER_UPDATE}
|
||||
result = self._run_module(UPDATE_PAYLOAD)
|
||||
|
||||
assert result['changed']
|
||||
assert OBJECT_AFTER_UPDATE.items() == result[api_call_object].items()
|
||||
|
||||
def test_update_idempotent(self, mocker, connection_mock):
|
||||
mock_function = mocker.patch(function_path)
|
||||
mock_function.return_value = {'changed': False, api_call_object: OBJECT_AFTER_UPDATE}
|
||||
result = self._run_module(UPDATE_PAYLOAD)
|
||||
|
||||
assert not result['changed']
|
||||
|
||||
def test_delete(self, mocker, connection_mock):
|
||||
mock_function = mocker.patch(function_path)
|
||||
mock_function.return_value = {'changed': True}
|
||||
result = self._run_module(DELETE_PAYLOAD)
|
||||
|
||||
assert result['changed']
|
||||
|
||||
def test_delete_idempotent(self, mocker, connection_mock):
|
||||
mock_function = mocker.patch(function_path)
|
||||
mock_function.return_value = {'changed': False}
|
||||
result = self._run_module(DELETE_PAYLOAD)
|
||||
|
||||
assert not result['changed']
|
||||
|
||||
def _run_module(self, module_args):
|
||||
set_module_args(module_args)
|
||||
with pytest.raises(AnsibleExitJson) as ex:
|
||||
self.module.main()
|
||||
return ex.value.args[0]
|
||||
@ -0,0 +1,82 @@
|
||||
# Ansible module to manage CheckPoint Firewall (c) 2019
|
||||
#
|
||||
# Ansible is free software: you can redistribute it and/or modify
|
||||
# it under the terms of the GNU General Public License as published by
|
||||
# the Free Software Foundation, either version 3 of the License, or
|
||||
# (at your option) any later version.
|
||||
#
|
||||
# Ansible is distributed in the hope that it will be useful,
|
||||
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
||||
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
||||
# GNU General Public License for more details.
|
||||
#
|
||||
# You should have received a copy of the GNU General Public License
|
||||
# along with Ansible. If not, see <http://www.gnu.org/licenses/>.
|
||||
#
|
||||
|
||||
from __future__ import absolute_import, division, print_function
|
||||
__metaclass__ = type
|
||||
|
||||
import pytest
|
||||
from units.modules.utils import set_module_args, exit_json, fail_json, AnsibleExitJson
|
||||
|
||||
from ansible.module_utils import basic
|
||||
from ansible.modules.network.check_point import cp_mgmt_address_range_facts
|
||||
|
||||
OBJECT = {
|
||||
"from": 1,
|
||||
"to": 1,
|
||||
"total": 6,
|
||||
"objects": [
|
||||
"53de74b7-8f19-4cbe-99fc-a81ef0759bad"
|
||||
]
|
||||
}
|
||||
|
||||
SHOW_PLURAL_PAYLOAD = {
|
||||
'limit': 1,
|
||||
'details_level': 'uid'
|
||||
}
|
||||
|
||||
SHOW_SINGLE_PAYLOAD = {
|
||||
'name': 'object_which_is_not_exist'
|
||||
}
|
||||
|
||||
api_call_object = 'address-range'
|
||||
api_call_object_plural_version = 'address-ranges'
|
||||
failure_msg = '''{u'message': u'Requested object [object_which_is_not_exist] not found', u'code': u'generic_err_object_not_found'}'''
|
||||
|
||||
|
||||
class TestCheckpointAddressRangeFacts(object):
|
||||
module = cp_mgmt_address_range_facts
|
||||
|
||||
@pytest.fixture(autouse=True)
|
||||
def module_mock(self, mocker):
|
||||
return mocker.patch.multiple(basic.AnsibleModule, exit_json=exit_json, fail_json=fail_json)
|
||||
|
||||
@pytest.fixture
|
||||
def connection_mock(self, mocker):
|
||||
connection_class_mock = mocker.patch('ansible.module_utils.network.checkpoint.checkpoint.Connection')
|
||||
return connection_class_mock.return_value
|
||||
|
||||
def test_show_single_object_which_is_not_exist(self, mocker, connection_mock):
|
||||
connection_mock.send_request.return_value = (404, failure_msg)
|
||||
try:
|
||||
result = self._run_module(SHOW_SINGLE_PAYLOAD)
|
||||
except Exception as e:
|
||||
result = e.args[0]
|
||||
|
||||
assert result['failed']
|
||||
assert 'Checkpoint device returned error 404 with message ' + failure_msg == result['msg']
|
||||
|
||||
def test_show_few_objects(self, mocker, connection_mock):
|
||||
connection_mock.send_request.return_value = (200, OBJECT)
|
||||
result = self._run_module(SHOW_PLURAL_PAYLOAD)
|
||||
|
||||
assert not result['changed']
|
||||
assert OBJECT == result['ansible_facts'][api_call_object_plural_version]
|
||||
|
||||
def _run_module(self, module_args):
|
||||
set_module_args(module_args)
|
||||
with pytest.raises(AnsibleExitJson) as ex:
|
||||
self.module.main()
|
||||
return ex.value.args[0]
|
||||
Loading…
Reference in New Issue