From 7888eafb820e22672df3a0051e2a1b48af8adf6d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20REY?= Date: Mon, 6 Jan 2020 17:32:36 +0100 Subject: [PATCH] Fix callback set_options issue with collections (#66128) Fixes: #66127 --- changelogs/fragments/66128-fix-callback-set-options.yml | 3 +++ lib/ansible/executor/task_queue_manager.py | 1 + 2 files changed, 4 insertions(+) create mode 100644 changelogs/fragments/66128-fix-callback-set-options.yml diff --git a/changelogs/fragments/66128-fix-callback-set-options.yml b/changelogs/fragments/66128-fix-callback-set-options.yml new file mode 100644 index 00000000000..b8d5f6f4c54 --- /dev/null +++ b/changelogs/fragments/66128-fix-callback-set-options.yml @@ -0,0 +1,3 @@ +--- +bugfixes: + - "Fix issue with callbacks ``set_options`` method that was not called with collections" diff --git a/lib/ansible/executor/task_queue_manager.py b/lib/ansible/executor/task_queue_manager.py index 475e71d1923..fabc4a92370 100644 --- a/lib/ansible/executor/task_queue_manager.py +++ b/lib/ansible/executor/task_queue_manager.py @@ -161,6 +161,7 @@ class TaskQueueManager: for callback_plugin_name in (c for c in C.DEFAULT_CALLBACK_WHITELIST if AnsibleCollectionRef.is_valid_fqcr(c)): # TODO: need to extend/duplicate the stdout callback check here (and possible move this ahead of the old way callback_obj = callback_loader.get(callback_plugin_name) + callback_obj.set_options() self._callback_plugins.append(callback_obj) self._callbacks_loaded = True