From 7794ad9f539630924294b96f5bcf6cbb18cb150e Mon Sep 17 00:00:00 2001
From: Jordan Borean <jborean93@gmail.com>
Date: Fri, 9 Nov 2018 05:36:13 +1000
Subject: [PATCH] gem: fix tests to work on newer Fedora hosts (#47158)
 (#47167)

(cherry picked from commit f720499337bb3913ab332a305eaa7f9e74bc2133)
---
 test/integration/targets/gem/tasks/main.yml | 113 ++++++++++++++++----
 1 file changed, 92 insertions(+), 21 deletions(-)

diff --git a/test/integration/targets/gem/tasks/main.yml b/test/integration/targets/gem/tasks/main.yml
index 77b93e663da..38ecbdb2561 100644
--- a/test/integration/targets/gem/tasks/main.yml
+++ b/test/integration/targets/gem/tasks/main.yml
@@ -32,24 +32,95 @@
     loop_var: package_item
   when: ansible_distribution != "MacOSX"
 
-- name: remove a gem
-  gem: name=gist state=absent
-
-- name: verify gist is not installed
-  shell: gem list | egrep '^gist '
-  register: uninstall
-  failed_when: "uninstall.rc != 1"
-
-- name: install a gem
-  gem: name=gist state=present
-  register: gem_result
-
-- name: verify module output properties
-  assert:
-    that:
-        - "'name' in gem_result"
-        - "'changed' in gem_result"
-        - "'state' in gem_result"
-
-- name: verify gist is installed
-  shell: gem list | egrep '^gist '
+- name: Install a gem
+  gem:
+    name: gist
+    state: present
+  register: install_gem_result
+  ignore_errors: yes
+
+# when running as root on Fedora, '--install-dir' is set in the os defaults which is
+# incompatible with '--user-install', we ignore this error for this case only
+- name: fail if failed to install gem
+  fail:
+    msg: "failed to install gem: {{ install_gem_result.msg }}"
+  when:
+  - install_gem_result is failed
+  - not (ansible_user_uid == 0 and "User --install-dir or --user-install but not both" not in install_gem_result.msg)
+
+- block:
+  - name: List gems
+    command: gem list
+    register: current_gems
+
+  - name: Ensure gem was installed
+    assert:
+      that:
+        - install_gem_result is changed
+        - current_gems.stdout is search('gist\s+\([0-9.]+\)')
+
+  - name: Remove a gem
+    gem:
+      name: gist
+      state: absent
+    register: remove_gem_results
+
+  - name: List gems
+    command: gem list
+    register: current_gems
+
+  - name: Verify gem is not installed
+    assert:
+      that:
+        - remove_gem_results is changed
+        - current_gems.stdout is not search('gist\s+\([0-9.]+\)')
+  when: not install_gem_result is failed
+
+# install gem in --no-user-install
+- block:
+  - name: Install a gem with --no-user-install
+    gem:
+      name: gist
+      state: present
+      user_install: no
+    register: install_gem_result
+
+  - name: List gems
+    command: gem list
+    register: current_gems
+
+  - name: Ensure gem was installed
+    assert:
+      that:
+        - install_gem_result is changed
+        - current_gems.stdout is search('gist\s+\([0-9.]+\)')
+
+  - name: Remove a gem
+    gem:
+      name: gist
+      state: absent
+    register: remove_gem_results
+
+  - name: List gems
+    command: gem list
+    register: current_gems
+
+  - name: Verify gem is not installed
+    assert:
+      that:
+        - remove_gem_results is changed
+        - current_gems.stdout is not search('gist\s+\([0-9.]+\)')
+  when: ansible_user_uid == 0
+
+# Check cutom gem directory
+- name: Install gem in a custom directory with incorrect options
+  gem:
+    name: gist
+    state: present
+    install_dir: "{{ output_dir }}/gems"
+  ignore_errors: yes
+  register: install_gem_fail_result
+
+- debug:
+    var: install_gem_fail_result
+  tags: debug