From 7362b8d08f5750aa8bec2eaf1d91a9ce1c216a63 Mon Sep 17 00:00:00 2001 From: Senthil Kumar Ganesan Date: Mon, 19 Sep 2016 00:50:28 -0700 Subject: [PATCH] Addressed review comments, given as part of other reviews (#4904) --- network/dellos10/dellos10_config.py | 11 +++++------ network/dellos6/dellos6_config.py | 2 +- network/dellos9/dellos9_command.py | 11 ++++++----- network/dellos9/dellos9_config.py | 4 ++-- 4 files changed, 14 insertions(+), 14 deletions(-) diff --git a/network/dellos10/dellos10_config.py b/network/dellos10/dellos10_config.py index e505799e0e8..1d976f011f1 100644 --- a/network/dellos10/dellos10_config.py +++ b/network/dellos10/dellos10_config.py @@ -180,21 +180,21 @@ updates: responses: description: The set of responses from issuing the commands on the device - retured: when not check_mode + returned: when not check_mode type: list sample: ['...', '...'] saved: - description: Returns whether the configuration is saved to the startup + description: Returns whether the configuration is saved to the startup configuration or not. - retured: when not check_mode + returned: when not check_mode type: bool sample: True """ from ansible.module_utils.netcfg import NetworkConfig, dumps from ansible.module_utils.network import NetworkModule -from ansible.module_utils.dellos10 import get_config, get_sublevel_config +from ansible.module_utils.dellos10 import get_config, get_sublevel_config def get_candidate(module): candidate = NetworkConfig(indent=1) @@ -220,11 +220,10 @@ def main(): match=dict(default='line', choices=['line', 'strict', 'exact', 'none']), replace=dict(default='line', choices=['line', 'block']), - update=dict(choices=['merge', 'check'], default='merge'), save=dict(type='bool', default=False), config=dict(), - backup =dict(type='bool', default=False) + backup=dict(type='bool', default=False) ) mutually_exclusive = [('lines', 'src')] diff --git a/network/dellos6/dellos6_config.py b/network/dellos6/dellos6_config.py index 153e1365241..1f4c4417356 100644 --- a/network/dellos6/dellos6_config.py +++ b/network/dellos6/dellos6_config.py @@ -194,7 +194,7 @@ saved: """ from ansible.module_utils.netcfg import dumps from ansible.module_utils.network import NetworkModule -from ansible.module_utils.dnos6 import get_config, get_sublevel_config, Dellos6NetworkConfig +from ansible.module_utils.dellos6 import get_config, get_sublevel_config, Dellos6NetworkConfig def get_candidate(module): diff --git a/network/dellos9/dellos9_command.py b/network/dellos9/dellos9_command.py index b6bc6ed9d70..a36c83a7b72 100755 --- a/network/dellos9/dellos9_command.py +++ b/network/dellos9/dellos9_command.py @@ -24,6 +24,7 @@ DOCUMENTATION = """ --- module: dellos9_command version_added: "2.2" +author: "Dhivya P (@dhivyap)" short_description: Run commands on remote devices running Dell OS9 description: - Sends arbitrary commands to a Dell OS9 node and returns the results @@ -83,22 +84,22 @@ tasks: - name: run show version on remote devices dellos9_command: commands: show version - provider "{{ cli }}" + provider: "{{ cli }}" - name: run show version and check to see if output contains OS9 dellos9_command: commands: show version wait_for: result[0] contains OS9 - provider "{{ cli }}" + provider: "{{ cli }}" - name: run multiple commands on remote nodes dellos9_command: commands: - show version - show interfaces - provider "{{ cli }}" + provider: "{{ cli }}" - - name: run multiple commands and evalute the output + - name: run multiple commands and evaluate the output dellos9_command: commands: - show version @@ -106,7 +107,7 @@ tasks: wait_for: - result[0] contains OS9 - result[1] contains Loopback - provider "{{ cli }}" + provider: "{{ cli }}" """ RETURN = """ diff --git a/network/dellos9/dellos9_config.py b/network/dellos9/dellos9_config.py index a90531b0f6c..1d728c5319b 100755 --- a/network/dellos9/dellos9_config.py +++ b/network/dellos9/dellos9_config.py @@ -180,14 +180,14 @@ updates: responses: description: The set of responses from issuing the commands on the device - retured: when not check_mode + returned: when not check_mode type: list sample: ['...', '...'] saved: description: Returns whether the configuration is saved to the startup configuration or not. - retured: when not check_mode + returned: when not check_mode type: bool sample: True