From 71961134be66e7b24983449629e82111c827d2ea Mon Sep 17 00:00:00 2001 From: Michael Gruener Date: Fri, 25 Mar 2016 19:19:11 +0100 Subject: [PATCH] cloudflare_dns: Allow CNAME content updates --- network/cloudflare_dns.py | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/network/cloudflare_dns.py b/network/cloudflare_dns.py index 5f0955f018c..88207ecf8d7 100644 --- a/network/cloudflare_dns.py +++ b/network/cloudflare_dns.py @@ -412,6 +412,14 @@ class CloudflareAPI(object): if (params['type'] in [ 'A','AAAA','CNAME','TXT','MX','NS','SPF']): if not params['value']: self.module.fail_json(msg="You must provide a non-empty value to create this record type") + + # there can only be one CNAME per record + # ignoring the value when searching for existing + # CNAME records allows us to update the value if it + # changes + if params['type'] == 'CNAME': + search_value = None + new_record = { "type": params['type'], "name": params['record'], @@ -468,6 +476,9 @@ class CloudflareAPI(object): if (cur_record['data'] > new_record['data']) - (cur_record['data'] < new_record['data']): cur_record['data'] = new_record['data'] do_update = True + if (type == 'CNAME') and (cur_record['content'] != new_record['content']): + cur_record['content'] = new_record['content'] + do_update = True if do_update: if not self.module.check_mode: result, info = self._cf_api_call('/zones/{0}/dns_records/{1}'.format(zone_id,records[0]['id']),'PUT',new_record)