From 70b0891f9536fa7be1faac8939efa9141b673e58 Mon Sep 17 00:00:00 2001 From: Dennis Conrad Date: Tue, 19 Apr 2016 18:53:21 +0100 Subject: [PATCH] Fix UnboundLocalError if 'access_key_ids' not supplied 'key_ids' is referenced before it is assigned, causing the module to fail with a UnboundLocalError instead of failing gracefully with a helpful error message. This very small patch moves the assignment of 'key_ids' to before the variable is referenced. --- lib/ansible/modules/cloud/amazon/iam.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ansible/modules/cloud/amazon/iam.py b/lib/ansible/modules/cloud/amazon/iam.py index a455ce40ede..02fba4bd88f 100644 --- a/lib/ansible/modules/cloud/amazon/iam.py +++ b/lib/ansible/modules/cloud/amazon/iam.py @@ -541,12 +541,12 @@ def main(): new_path = module.params.get('new_path') key_count = module.params.get('key_count') key_state = module.params.get('access_key_state') + key_ids = module.params.get('access_key_ids') if key_state: key_state = key_state.lower() if any([n in key_state for n in ['active', 'inactive']]) and not key_ids: module.fail_json(changed=False, msg="At least one access key has to be defined in order" " to use 'active' or 'inactive'") - key_ids = module.params.get('access_key_ids') if iam_type == 'user' and module.params.get('password') is not None: pwd = module.params.get('password')