Address FIXME's in sysctl.py (#69175)

* Address FIXME's in sysctl.py

* Added changelog fragment

* Updated check

* Update conditions

* if not instead of is None

* Restore and delete FIXME comments
pull/69337/head
Chris Holland 5 years ago committed by GitHub
parent cdad594b16
commit 70219df905
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -0,0 +1,2 @@
bugfixes:
- sysctl - Remove FIXME comments to avoid confusion

@ -26,7 +26,6 @@ class VirtualSysctlDetectionMixin(object):
def detect_virt_product(self, key):
virtual_product_facts = {}
self.detect_sysctl()
# FIXME: exit early on falsey self.sysctl_path and unindent
if self.sysctl_path:
rc, out, err = self.module.run_command("%s -n %s" % (self.sysctl_path, key))
if rc == 0:
@ -57,7 +56,6 @@ class VirtualSysctlDetectionMixin(object):
def detect_virt_vendor(self, key):
virtual_vendor_facts = {}
self.detect_sysctl()
# FIXME: exit early on falsey self.sysctl_path and unindent
if self.sysctl_path:
rc, out, err = self.module.run_command("%s -n %s" % (self.sysctl_path, key))
if rc == 0:

Loading…
Cancel
Save