From 6e19e341b045cc035e3d1c089b8ca8a28aea9ba6 Mon Sep 17 00:00:00 2001 From: Jan Orel Date: Fri, 8 Nov 2019 23:59:33 +0100 Subject: [PATCH] one_vm: Fix creating VM also for template_id=0 (#63579) --- lib/ansible/modules/cloud/opennebula/one_vm.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/ansible/modules/cloud/opennebula/one_vm.py b/lib/ansible/modules/cloud/opennebula/one_vm.py index b7a4c5f90e3..14c0b5feb6a 100644 --- a/lib/ansible/modules/cloud/opennebula/one_vm.py +++ b/lib/ansible/modules/cloud/opennebula/one_vm.py @@ -644,7 +644,7 @@ def get_template_by_id(module, client, template_id): def get_template_id(module, client, requested_id, requested_name): - template = get_template_by_id(module, client, requested_id) if requested_id else get_template_by_name(module, client, requested_name) + template = get_template_by_id(module, client, requested_id) if requested_id is not None else get_template_by_name(module, client, requested_name) if template: return template.ID else: @@ -1430,10 +1430,10 @@ def main(): # Fetch template template_id = None - if requested_template_id or requested_template_name: + if requested_template_id is not None or requested_template_name: template_id = get_template_id(module, one_client, requested_template_id, requested_template_name) if template_id is None: - if requested_template_id: + if requested_template_id is not None: module.fail_json(msg='There is no template with template_id: ' + str(requested_template_id)) elif requested_template_name: module.fail_json(msg="There is no template with name: " + requested_template_name)