Added fix for bug 63290 (#63308)

lib/ansible/modules/network/eos/eos_logging.py

@@ -194,12 +194,12 @@ def map_obj_to_commands(updates, module):
                         commands.append('logging buffered {0}'.format(size))
 
             else:
-                dest_cmd = 'logging {0}'.format(dest)
-                if level:
-                    dest_cmd += ' {0}'.format(level)
-
-                commands.append(dest_cmd)
+                if dest:
+                    dest_cmd = 'logging {0}'.format(dest)
+                    if level:
+                        dest_cmd += ' {0}'.format(level)
 
+                    commands.append(dest_cmd)
     return commands
 
 

test/integration/targets/eos_logging/tests/cli/basic.yaml

@@ -107,12 +107,35 @@
     that:
       - 'result.changed == false'
 
+- name: Set up logging facility alone
+  eos_logging:
+    facility: local2
+    state: present
+  become: yes
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == true'
+      - '"logging facility local2" in result.commands'
+
+- name: Set up logging facility (idempotent)
+  eos_logging:
+    facility: local2
+    state: present
+  become: yes
+  register: result
+
+- assert:
+    that:
+      - 'result.changed == false'
+
 - name: remove logging as collection tearDown
   eos_logging:
     aggregate:
       - { dest: console, level: warnings, state: absent }
       - { dest: buffered, level: informational, size: 4096, state: absent }
-      - { facility: local7, state: absent }
+      - { facility: local2, state: absent }
   become: yes
   register: result
 
@@ -121,4 +144,4 @@
       - 'result.changed == true'
       - '"no logging console" in result.commands'
       - '"no logging buffered" in result.commands'
-      - '"no logging facility local7" in result.commands'
+      - '"no logging facility local2" in result.commands'