From 6c1687e68eb424f56eb1157266436f1c68200a40 Mon Sep 17 00:00:00 2001 From: whiter Date: Wed, 18 Mar 2015 14:52:49 +1100 Subject: [PATCH] Added changed=True flag when new subnet groups created. Added conditional so that modify_db_subnet_group is only called when necessary and changed=True flag will be set. --- cloud/amazon/rds_subnet_group.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/cloud/amazon/rds_subnet_group.py b/cloud/amazon/rds_subnet_group.py index 9731154f77c..bfe0fe072d0 100644 --- a/cloud/amazon/rds_subnet_group.py +++ b/cloud/amazon/rds_subnet_group.py @@ -149,10 +149,14 @@ def main(): else: if not exists: new_group = conn.create_db_subnet_group(group_name, desc=group_description, subnet_ids=group_subnets) - + changed = True else: - changed_group = conn.modify_db_subnet_group(group_name, description=group_description, subnet_ids=group_subnets) - + # Sort the subnet groups before we compare them + matching_groups[0].subnet_ids.sort() + group_subnets.sort() + if ( (matching_groups[0].name != group_name) or (matching_groups[0].description != group_description) or (matching_groups[0].subnet_ids != group_subnets) ): + changed_group = conn.modify_db_subnet_group(group_name, description=group_description, subnet_ids=group_subnets) + changed = True except BotoServerError, e: module.fail_json(msg = e.error_message)