From 6b7d669a2bac0910ae19b80f16c8e86c4d76ac35 Mon Sep 17 00:00:00 2001 From: Dag Wieers Date: Thu, 18 May 2017 09:25:38 +0200 Subject: [PATCH] win_psexec: Change default for -nobanner (#24739) * win_psexec: Change default for -nobanner * Update documentation too --- lib/ansible/modules/windows/win_psexec.ps1 | 2 +- lib/ansible/modules/windows/win_psexec.py | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/ansible/modules/windows/win_psexec.ps1 b/lib/ansible/modules/windows/win_psexec.ps1 index 2d51958c0ed..6a3e1479da0 100644 --- a/lib/ansible/modules/windows/win_psexec.ps1 +++ b/lib/ansible/modules/windows/win_psexec.ps1 @@ -30,7 +30,7 @@ $username = Get-AnsibleParam -obj $params -name "username" -type "str" $password = Get-AnsibleParam -obj $params -name "password" -type "str" $chdir = Get-AnsibleParam -obj $params -name "chdir" -type "path" $wait = Get-AnsibleParam -obj $params -name "wait" -type "bool" -default $true -$nobanner = Get-AnsibleParam -obj $params -name "nobanner" -type "bool" -default $true +$nobanner = Get-AnsibleParam -obj $params -name "nobanner" -type "bool" -default $false $noprofile = Get-AnsibleParam -obj $params -name "noprofile" -type "bool" -default $false $elevated = Get-AnsibleParam -obj $params -name "elevated" -type "bool" -default $false $limited = Get-AnsibleParam -obj $params -name "limited" -type "bool" -default $false diff --git a/lib/ansible/modules/windows/win_psexec.py b/lib/ansible/modules/windows/win_psexec.py index 98200359175..5a13e15daba 100644 --- a/lib/ansible/modules/windows/win_psexec.py +++ b/lib/ansible/modules/windows/win_psexec.py @@ -58,7 +58,8 @@ options: nobanner: description: - Do not display the startup banner and copyright message. - default: 'yes' + - This only works for specific versions of the PsExec binary. + default: 'no' choices: [ 'no', 'yes' ] version_added: '2.4' noprofile: