From 6503aea5fe6eb44a567ce9319b8efaca4d00bdc4 Mon Sep 17 00:00:00 2001
From: Michael DeHaan <michael@ansibleworks.com>
Date: Sat, 1 Jun 2013 12:20:45 -0400
Subject: [PATCH] Docs standardization

---
 system/zfs | 36 +++++++++++++++++++-----------------
 1 file changed, 19 insertions(+), 17 deletions(-)

diff --git a/system/zfs b/system/zfs
index a4475e9aed3..adfe3069f09 100644
--- a/system/zfs
+++ b/system/zfs
@@ -50,12 +50,12 @@ options:
     description:
       - The atime property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   canmount:
     description:
       - The canmount property.
     required: False
-    choices: [on,off,noauto]
+    choices: ['on','off','noauto']
   casesensitivity:
     description:
       - The casesensitivity property.
@@ -65,12 +65,12 @@ options:
     description:
       - The checksum property.
     required: False
-    choices: [on,off,fletcher2,fletcher4,sha256]
+    choices: ['on','off',fletcher2,fletcher4,sha256]
   compression:
     description:
       - The compression property.
     required: False
-    choices: [on,off,lzjb,gzip,gzip-1,gzip-2,gzip-3,gzip-4,gzip-5,gzip-6,gzip-7,gzip-8,gzip-9]
+    choices: ['on','off',lzjb,gzip,gzip-1,gzip-2,gzip-3,gzip-4,gzip-5,gzip-6,gzip-7,gzip-8,gzip-9]
   copies:
     description:
       - The copies property.
@@ -80,22 +80,22 @@ options:
     description:
       - The dedup property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   devices:
     description:
       - The devices property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   exec:
     description:
       - The exec property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   jailed:
     description:
       - The jailed property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   logbias:
     description:
       - The logbias property.
@@ -109,7 +109,7 @@ options:
     description:
       - The nbmand property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   normalization:
     description:
       - The normalization property.
@@ -128,7 +128,7 @@ options:
     description:
       - The readonly property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   recordsize:
     description:
       - The recordsize property.
@@ -154,12 +154,12 @@ options:
     description:
       - The setuid property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   shareiscsi:
     description:
       - The shareiscsi property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   sharenfs:
     description:
       - The sharenfs property.
@@ -177,12 +177,12 @@ options:
     description:
       - The sync property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   utf8only:
     description:
       - The utf8only property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   volsize:
     description:
       - The volsize property.
@@ -195,17 +195,17 @@ options:
     description:
       - The vscan property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   xattr:
     description:
       - The xattr property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
   zoned:
     description:
       - The zoned property.
     required: False
-    choices: [on,off]
+    choices: ['on','off']
 examples:
   - code: zfs name=rpool/myfs state=present
     description: Create a new file system called myfs in pool rpool
@@ -321,6 +321,8 @@ class Zfs(object):
         return module.run_command(cmd)
 
 def main():
+
+    # FIXME: should use dict() constructor like other modules, required=False is default
     module = AnsibleModule(
         argument_spec = {
             'name':            {'required': True},