Fixes Netconf_config single parameter bug (#56138)

* Fixes Netconf_config single parameter bug
Fixes 56022

fixed get_config to not require multiple parameters to just run a backup

* Add Integration test for netconf_config
Associated with #56022

tests backup through netconf only using one parameter.

* Added debug to the begin and end of file

* Fix formatting of save config.  #56022

* removed blank line at end: #56022
pull/56148/head
wjohnston888 6 years ago committed by Ganesh Nalawade
parent 9db3c8a40b
commit 647ed207af

@ -76,7 +76,7 @@ def locked_config(module, target=None):
unlock_configuration(module, target=target) unlock_configuration(module, target=target)
def get_config(module, source, filter, lock=False): def get_config(module, source, filter=None, lock=False):
conn = get_connection(module) conn = get_connection(module)
try: try:
locked = False locked = False

@ -381,7 +381,7 @@ def main():
if not module.check_mode: if not module.check_mode:
conn.commit() conn.commit()
result['changed'] = True result['changed'] = True
else: elif config:
if module.check_mode and not supports_commit: if module.check_mode and not supports_commit:
module.warn("check mode not supported as Netconf server doesn't support candidate capability") module.warn("check mode not supported as Netconf server doesn't support candidate capability")
result['changed'] = True result['changed'] = True

@ -0,0 +1,13 @@
---
- debug: msg="START netconf_config iosxr/basic.yaml on connection={{ ansible_connection }}"
- name: save config test
netconf_config:
backup: yes
register: result
- assert:
that:
- "'backup_path' in result"
- debug: msg="END netconf_config iosxr/basic.yaml on connection={{ ansible_connection }}"

@ -52,4 +52,13 @@
lines: lines:
- delete system syslog file test_netconf_config - delete system syslog file test_netconf_config
- name: save config
netconf_config:
backup: yes
register: result
- assert:
that:
- "'backup_path' in result"
- debug: msg="END netconf_config junos/basic.yaml on connection={{ ansible_connection }}" - debug: msg="END netconf_config junos/basic.yaml on connection={{ ansible_connection }}"

Loading…
Cancel
Save