mirror of https://github.com/ansible/ansible.git
[cloud] Update RDS parameter group for boto3 (#25345)
* Update RDS parameter group for boto3 * Update to boto3 * Update to latest ansible standards * Remove choices list for valid engines (See #19221 for context) * Allow tagging * Return some useful information, and document that information * Add tests for rds_param_group * Improve testing of rds_param_group * Add purge_tags option for rds_param_group * Fix remaining broken rds_param_group tests * Ensure the group name is lowercased. Fixes integration tests when run on OSXpull/28731/head
Will Thames
7 years ago
committed by
Ryan Brown
parent
f08c29924e
commit
63df0adc17
@ -0,0 +1,2 @@
|
||||
cloud/aws
|
||||
posix/ci/cloud/aws
|
||||
@ -0,0 +1,30 @@
|
||||
---
|
||||
rds_param_group:
|
||||
name: "{{ resource_prefix}}rds-param-group"
|
||||
description: "Test group for rds_param_group Ansible module"
|
||||
engine: postgres9.6
|
||||
|
||||
rds_long_param_list:
|
||||
application_name: Test
|
||||
logging_collector: on
|
||||
log_directory: /var/log/postgresql
|
||||
log_filename: postgresql.log.%Y-%m-%d-%H
|
||||
log_file_mode: 0600
|
||||
event_source: RDS
|
||||
log_min_messages: INFO
|
||||
log_min_duration_statement: 500
|
||||
log_rotation_age: 60
|
||||
debug_print_parse: on
|
||||
debug_print_rewritten: on
|
||||
debug_print_plan: on
|
||||
debug_pretty_print: on
|
||||
log_checkpoints: on
|
||||
log_connections: on
|
||||
log_disconnections: on
|
||||
log_duration: on
|
||||
log_error_verbosity: VERBOSE
|
||||
log_lock_waits: on
|
||||
log_temp_files: 10K
|
||||
log_timezone: UTC
|
||||
log_statement: 'all'
|
||||
log_replication_commands: on
|
||||
@ -0,0 +1,3 @@
|
||||
dependencies:
|
||||
- prepare_tests
|
||||
- setup_ec2
|
||||
@ -0,0 +1,321 @@
|
||||
---
|
||||
# A Note about ec2 environment variable name preference:
|
||||
# - EC2_URL -> AWS_URL
|
||||
# - EC2_ACCESS_KEY -> AWS_ACCESS_KEY_ID -> AWS_ACCESS_KEY
|
||||
# - EC2_SECRET_KEY -> AWS_SECRET_ACCESS_KEY -> AWX_SECRET_KEY
|
||||
# - EC2_REGION -> AWS_REGION
|
||||
#
|
||||
# TODO - name: test 'region' parameter
|
||||
# TODO - name: test 'state=absent' parameter for existing key
|
||||
# TODO - name: test 'state=absent' parameter for missing key
|
||||
# TODO - name: test 'validate_certs' parameter
|
||||
|
||||
# ============================================================
|
||||
# - include: ../../setup_ec2/tasks/common.yml module_name=rds_param_group
|
||||
|
||||
- block:
|
||||
|
||||
# ============================================================
|
||||
- name: test empty parameter group
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
description: "{{ rds_param_group.description }}"
|
||||
state: present
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert rds parameter group changed
|
||||
assert:
|
||||
that:
|
||||
- 'result.changed'
|
||||
- "'{{ result.db_parameter_group_name | lower }}' == '{{ rds_param_group.name | lower }}'"
|
||||
- 'result.tags == {}'
|
||||
|
||||
# ============================================================
|
||||
- name: test empty parameter group with no arguments changes nothing
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
description: "{{ rds_param_group.description }}"
|
||||
state: present
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert no change when running empty parameter group a second time
|
||||
assert:
|
||||
that:
|
||||
- 'not result.changed'
|
||||
|
||||
# ============================================================
|
||||
- name: test adding numeric tag
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
description: "{{ rds_param_group.description }}"
|
||||
state: present
|
||||
tags:
|
||||
Environment: test
|
||||
Test: 123
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: adding numeric tag just silently converts
|
||||
assert:
|
||||
that:
|
||||
- 'result.changed'
|
||||
- 'result.tags.Test == "123"'
|
||||
|
||||
# ============================================================
|
||||
- name: test tagging existing group
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
description: "{{ rds_param_group.description }}"
|
||||
state: present
|
||||
tags:
|
||||
Environment: test
|
||||
Test: "123"
|
||||
NewTag: "hello"
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert tagging existing group changes it and adds tags
|
||||
assert:
|
||||
that:
|
||||
- 'result.changed'
|
||||
- 'result.tags.NewTag == "hello"'
|
||||
|
||||
# ============================================================
|
||||
- name: test repeating tagging existing group
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
description: "{{ rds_param_group.description }}"
|
||||
state: present
|
||||
tags:
|
||||
Environment: test
|
||||
Test: "123"
|
||||
NewTag: "hello"
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert tagging existing group changes it and adds tags
|
||||
assert:
|
||||
that:
|
||||
- 'not result.changed'
|
||||
- 'result.tags.Test == "123"'
|
||||
|
||||
# ============================================================
|
||||
- name: test deleting tags from existing group
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
description: "{{ rds_param_group.description }}"
|
||||
state: present
|
||||
tags:
|
||||
Environment: test
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
purge_tags: yes
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert removing tags from existing group changes it
|
||||
assert:
|
||||
that:
|
||||
- 'result.changed'
|
||||
- 'result.tags.Environment == "test"'
|
||||
- '"NewTag" not in result.tags'
|
||||
|
||||
# ============================================================
|
||||
- name: test state=absent with engine defined (expect changed=true)
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
state: absent
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert state=absent with engine defined (expect changed=true)
|
||||
assert:
|
||||
that:
|
||||
- 'result.changed'
|
||||
|
||||
# ============================================================
|
||||
- name: test creating group with parameters
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
description: "{{ rds_param_group.description }}"
|
||||
state: present
|
||||
params:
|
||||
log_directory: /var/log/postgresql
|
||||
log_statement: 'all'
|
||||
log_duration: on
|
||||
this_param_does_not_exist: oh_no
|
||||
tags:
|
||||
Environment: test
|
||||
Test: "123"
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert creating a new group with parameter changes it
|
||||
assert:
|
||||
that:
|
||||
- 'result.changed'
|
||||
- 'result.tags.Test == "123"'
|
||||
- 'result.errors|length == 2'
|
||||
|
||||
# ============================================================
|
||||
- name: test repeating group with parameters
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
description: "{{ rds_param_group.description }}"
|
||||
state: present
|
||||
params:
|
||||
log_directory: /var/log/postgresql
|
||||
log_statement: 'all'
|
||||
log_duration: on
|
||||
this_param_does_not_exist: oh_no
|
||||
tags:
|
||||
Environment: test
|
||||
Test: "123"
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert repeating group with parameters does not change it
|
||||
assert:
|
||||
that:
|
||||
- 'not result.changed'
|
||||
- 'result.tags.Test == "123"'
|
||||
- 'result.errors|length == 2'
|
||||
|
||||
# ============================================================
|
||||
- name: test state=absent with engine defined (expect changed=true)
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
state: absent
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert state=absent with engine defined (expect changed=true)
|
||||
assert:
|
||||
that:
|
||||
- 'result.changed'
|
||||
|
||||
# ============================================================
|
||||
- name: test repeating state=absent (expect changed=false)
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
state: absent
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert repeating state=absent (expect changed=false)
|
||||
assert:
|
||||
that:
|
||||
- 'not result.changed'
|
||||
|
||||
# ============================================================
|
||||
- name: test creating group with more than 20 parameters
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
description: "{{ rds_param_group.description }}"
|
||||
params: "{{ rds_long_param_list }}"
|
||||
state: present
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert creating a new group with lots of parameter changes it
|
||||
assert:
|
||||
that:
|
||||
- 'result.changed'
|
||||
|
||||
# ============================================================
|
||||
- name: test creating group with more than 20 parameters
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
engine: "{{ rds_param_group.engine }}"
|
||||
description: "{{ rds_param_group.description }}"
|
||||
params: "{{ rds_long_param_list }}"
|
||||
region: "{{ ec2_region }}"
|
||||
state: present
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert repeating a group with lots of parameter does not change it
|
||||
assert:
|
||||
that:
|
||||
- 'not result.changed'
|
||||
|
||||
always:
|
||||
# ============================================================
|
||||
- name: test state=absent (expect changed=false)
|
||||
rds_param_group:
|
||||
name: "{{ rds_param_group.name }}"
|
||||
state: absent
|
||||
region: "{{ ec2_region }}"
|
||||
ec2_access_key: '{{ aws_access_key }}'
|
||||
ec2_secret_key: '{{ aws_secret_key }}'
|
||||
security_token: '{{ security_token }}'
|
||||
register: result
|
||||
ignore_errors: true
|
||||
|
||||
- name: assert state=absent (expect changed=false)
|
||||
assert:
|
||||
that:
|
||||
- 'result.changed'
|
||||
Loading…
Reference in New Issue