archive
/
ansible
mirror of https://github.com/ansible/ansible.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Fortinet's new module for fortios_switch_controller_vlan (#59630)

Browse Source 
* Fortinet's new module for fortios_switch_controller_vlan

* Update fortios_switch_controller_vlan.py

* Update fortios_switch_controller_vlan.py
pull/59532/head
Miguel Angel Muñoz González 5 years ago committed by Nilashish Chakraborty
parent f1a4ab0aa5
commit 60a1545092
2 changed files with 712 additions and 0 deletions
Show Stats Download Patch File Download Diff File

423
lib/ansible/modules/network/fortios/fortios_switch_controller_vlan.py
Unescape Escape View File

@ -0,0 +1,423 @@
#!/usr/bin/python
from __future__ import (absolute_import, division, print_function)
# Copyright 2019 Fortinet, Inc.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <https://www.gnu.org/licenses/>.
__metaclass__ = type
ANSIBLE_METADATA = {'status': ['preview'],
'supported_by': 'community',
'metadata_version': '1.1'}
DOCUMENTATION = '''
---
module: fortios_switch_controller_vlan
short_description: Configure VLANs for switch controller in Fortinet's FortiOS and FortiGate.
description:
- This module is able to configure a FortiGate or FortiOS device by allowing the
user to set and modify switch_controller feature and vlan category.
Examples include all parameters and values need to be adjusted to datasources before usage.
Tested with FOS v6.0.5
version_added: "2.9"
author:
- Miguel Angel Munoz (@mamunozgonzalez)
- Nicolas Thomas (@thomnico)
notes:
- Requires fortiosapi library developed by Fortinet
- Run as a local_action in your playbook
requirements:
- fortiosapi>=0.9.8
options:
host:
description:
- FortiOS or FortiGate IP address.
type: str
required: true
username:
description:
- FortiOS or FortiGate username.
type: str
required: true
password:
description:
- FortiOS or FortiGate password.
type: str
default: ""
vdom:
description:
- Virtual domain, among those defined previously. A vdom is a
virtual instance of the FortiGate that can be configured and
used as a different unit.
type: str
default: root
https:
description:
- Indicates if the requests towards FortiGate must use HTTPS protocol.
type: bool
default: true
ssl_verify:
description:
- Ensures FortiGate certificate must be verified by a proper CA.
type: bool
default: true
state:
description:
- Indicates whether to create or remove the object.
type: str
choices:
- present
- absent
switch_controller_vlan:
description:
- Configure VLANs for switch controller.
default: null
type: dict
suboptions:
auth:
description:
- Authentication.
type: str
choices:
- radius
- usergroup
color:
description:
- Color of icon on the GUI.
type: int
comments:
description:
- Comment.
type: str
name:
description:
- Switch VLAN name.
required: true
type: str
portal_message_override_group:
description:
- Specify captive portal replacement message override group.
type: str
portal_message_overrides:
description:
- Individual message overrides.
type: dict
suboptions:
auth_disclaimer_page:
description:
- Override auth-disclaimer-page message with message from portal-message-overrides group.
type: str
auth_login_failed_page:
description:
- Override auth-login-failed-page message with message from portal-message-overrides group.
type: str
auth_login_page:
description:
- Override auth-login-page message with message from portal-message-overrides group.
type: str
auth_reject_page:
description:
- Override auth-reject-page message with message from portal-message-overrides group.
type: str
radius_server:
description:
- Authentication radius server. Source user.radius.name.
type: str
security:
description:
- Security.
type: str
choices:
- open
- captive-portal
- 8021x
selected_usergroups:
description:
- Selected user group.
type: list
suboptions:
name:
description:
- User group name. Source user.group.name.
required: true
type: str
usergroup:
description:
- Authentication usergroup. Source user.group.name.
type: str
vdom:
description:
- Virtual domain,
type: str
vlanid:
description:
- VLAN ID.
type: int
'''
EXAMPLES = '''
- hosts: localhost
vars:
host: "192.168.122.40"
username: "admin"
password: ""
vdom: "root"
ssl_verify: "False"
tasks:
- name: Configure VLANs for switch controller.
fortios_switch_controller_vlan:
host: "{{ host }}"
username: "{{ username }}"
password: "{{ password }}"
vdom: "{{ vdom }}"
https: "False"
state: "present"
switch_controller_vlan:
auth: "radius"
color: "4"
comments: "<your_own_value>"
name: "default_name_6"
portal_message_override_group: "<your_own_value>"
portal_message_overrides:
auth_disclaimer_page: "<your_own_value>"
auth_login_failed_page: "<your_own_value>"
auth_login_page: "<your_own_value>"
auth_reject_page: "<your_own_value>"
radius_server: "<your_own_value> (source user.radius.name)"
security: "open"
selected_usergroups:
-
name: "default_name_16 (source user.group.name)"
usergroup: "<your_own_value> (source user.group.name)"
vdom: "<your_own_value>"
vlanid: "19"
'''
RETURN = '''
build:
description: Build number of the fortigate image
returned: always
type: str
sample: '1547'
http_method:
description: Last method used to provision the content into FortiGate
returned: always
type: str
sample: 'PUT'
http_status:
description: Last result given by FortiGate on last operation applied
returned: always
type: str
sample: "200"
mkey:
description: Master key (id) used in the last call to FortiGate
returned: success
type: str
sample: "id"
name:
description: Name of the table used to fulfill the request
returned: always
type: str
sample: "urlfilter"
path:
description: Path of the table used to fulfill the request
returned: always
type: str
sample: "webfilter"
revision:
description: Internal revision number
returned: always
type: str
sample: "17.0.2.10658"
serial:
description: Serial number of the unit
returned: always
type: str
sample: "FGVMEVYYQT3AB5352"
status:
description: Indication of the operation's result
returned: always
type: str
sample: "success"
vdom:
description: Virtual domain used
returned: always
type: str
sample: "root"
version:
description: Version of the FortiGate
returned: always
type: str
sample: "v5.6.3"
'''
from ansible.module_utils.basic import AnsibleModule
from ansible.module_utils.connection import Connection
from ansible.module_utils.network.fortios.fortios import FortiOSHandler
from ansible.module_utils.network.fortimanager.common import FAIL_SOCKET_MSG
def login(data, fos):
host = data['host']
username = data['username']
password = data['password']
ssl_verify = data['ssl_verify']
fos.debug('on')
if 'https' in data and not data['https']:
fos.https('off')
else:
fos.https('on')
fos.login(host, username, password, verify=ssl_verify)
def filter_switch_controller_vlan_data(json):
option_list = ['auth', 'color', 'comments',
'name', 'portal_message_override_group', 'portal_message_overrides',
'radius_server', 'security', 'selected_usergroups',
'usergroup', 'vdom', 'vlanid']
dictionary = {}
for attribute in option_list:
if attribute in json and json[attribute] is not None:
dictionary[attribute] = json[attribute]
return dictionary
def underscore_to_hyphen(data):
if isinstance(data, list):
for elem in data:
elem = underscore_to_hyphen(elem)
elif isinstance(data, dict):
new_data = {}
for k, v in data.items():
new_data[k.replace('_', '-')] = underscore_to_hyphen(v)
data = new_data
return data
def switch_controller_vlan(data, fos):
vdom = data['vdom']
state = data['state']
switch_controller_vlan_data = data['switch_controller_vlan']
filtered_data = underscore_to_hyphen(filter_switch_controller_vlan_data(switch_controller_vlan_data))
if state == "present":
return fos.set('switch-controller',
'vlan',
data=filtered_data,
vdom=vdom)
elif state == "absent":
return fos.delete('switch-controller',
'vlan',
mkey=filtered_data['name'],
vdom=vdom)
def is_successful_status(status):
return status['status'] == "success" or \
status['http_method'] == "DELETE" and status['http_status'] == 404
def fortios_switch_controller(data, fos):
if data['switch_controller_vlan']:
resp = switch_controller_vlan(data, fos)
return not is_successful_status(resp), \
resp['status'] == "success", \
resp
def main():
fields = {
"host": {"required": False, "type": "str"},
"username": {"required": False, "type": "str"},
"password": {"required": False, "type": "str", "no_log": True},
"vdom": {"required": False, "type": "str", "default": "root"},
"https": {"required": False, "type": "bool", "default": True},
"ssl_verify": {"required": False, "type": "bool", "default": True},
"state": {"required": True, "type": "str",
"choices": ["present", "absent"]},
"switch_controller_vlan": {
"required": False, "type": "dict", "default": None,
"options": {
"auth": {"required": False, "type": "str",
"choices": ["radius", "usergroup"]},
"color": {"required": False, "type": "int"},
"comments": {"required": False, "type": "str"},
"name": {"required": True, "type": "str"},
"portal_message_override_group": {"required": False, "type": "str"},
"portal_message_overrides": {"required": False, "type": "dict",
"options": {
"auth_disclaimer_page": {"required": False, "type": "str"},
"auth_login_failed_page": {"required": False, "type": "str"},
"auth_login_page": {"required": False, "type": "str"},
"auth_reject_page": {"required": False, "type": "str"}
}},
"radius_server": {"required": False, "type": "str"},
"security": {"required": False, "type": "str",
"choices": ["open", "captive-portal", "8021x"]},
"selected_usergroups": {"required": False, "type": "list",
"options": {
"name": {"required": True, "type": "str"}
}},
"usergroup": {"required": False, "type": "str"},
"vdom": {"required": False, "type": "str"},
"vlanid": {"required": False, "type": "int"}
}
}
}
module = AnsibleModule(argument_spec=fields,
supports_check_mode=False)
legacy_mode = 'host' in module.params and module.params['host'] is not None and \
'username' in module.params and module.params['username'] is not None and \
'password' in module.params and module.params['password'] is not None
if not legacy_mode:
if module._socket_path:
connection = Connection(module._socket_path)
fos = FortiOSHandler(connection)
is_error, has_changed, result = fortios_switch_controller(module.params, fos)
else:
module.fail_json(**FAIL_SOCKET_MSG)
else:
try:
from fortiosapi import FortiOSAPI
except ImportError:
module.fail_json(msg="fortiosapi module is required")
fos = FortiOSAPI()
login(module.params, fos)
is_error, has_changed, result = fortios_switch_controller(module.params, fos)
fos.logout()
if not is_error:
module.exit_json(changed=has_changed, meta=result)
else:
module.fail_json(msg="Error in repo", meta=result)
if __name__ == '__main__':
main()

289
test/units/modules/network/fortios/test_fortios_switch_controller_vlan.py
Unescape Escape View File

@ -0,0 +1,289 @@
# Copyright 2019 Fortinet, Inc.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with Ansible. If not, see <https://www.gnu.org/licenses/>.
# Make coding more python3-ish
from __future__ import (absolute_import, division, print_function)
__metaclass__ = type
import os
import json
import pytest
from mock import ANY
from ansible.module_utils.network.fortios.fortios import FortiOSHandler
try:
from ansible.modules.network.fortios import fortios_switch_controller_vlan
except ImportError:
pytest.skip("Could not load required modules for testing", allow_module_level=True)
@pytest.fixture(autouse=True)
def connection_mock(mocker):
connection_class_mock = mocker.patch('ansible.modules.network.fortios.fortios_switch_controller_vlan.Connection')
return connection_class_mock
fos_instance = FortiOSHandler(connection_mock)
def test_switch_controller_vlan_creation(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
set_method_result = {'status': 'success', 'http_method': 'POST', 'http_status': 200}
set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result)
input_data = {
'username': 'admin',
'state': 'present',
'switch_controller_vlan': {
'auth': 'radius',
'color': '4',
'comments': 'test_value_5',
'name': 'default_name_6',
'portal_message_override_group': 'test_value_7',
'radius_server': 'test_value_8',
'security': 'open',
'usergroup': 'test_value_10',
'vdom': 'test_value_11',
'vlanid': '12'
},
'vdom': 'root'}
is_error, changed, response = fortios_switch_controller_vlan.fortios_switch_controller(input_data, fos_instance)
expected_data = {
'auth': 'radius',
'color': '4',
'comments': 'test_value_5',
'name': 'default_name_6',
'portal-message-override-group': 'test_value_7',
'radius-server': 'test_value_8',
'security': 'open',
'usergroup': 'test_value_10',
'vdom': 'test_value_11',
'vlanid': '12'
}
set_method_mock.assert_called_with('switch-controller', 'vlan', data=expected_data, vdom='root')
schema_method_mock.assert_not_called()
assert not is_error
assert changed
assert response['status'] == 'success'
assert response['http_status'] == 200
def test_switch_controller_vlan_creation_fails(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
set_method_result = {'status': 'error', 'http_method': 'POST', 'http_status': 500}
set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result)
input_data = {
'username': 'admin',
'state': 'present',
'switch_controller_vlan': {
'auth': 'radius',
'color': '4',
'comments': 'test_value_5',
'name': 'default_name_6',
'portal_message_override_group': 'test_value_7',
'radius_server': 'test_value_8',
'security': 'open',
'usergroup': 'test_value_10',
'vdom': 'test_value_11',
'vlanid': '12'
},
'vdom': 'root'}
is_error, changed, response = fortios_switch_controller_vlan.fortios_switch_controller(input_data, fos_instance)
expected_data = {
'auth': 'radius',
'color': '4',
'comments': 'test_value_5',
'name': 'default_name_6',
'portal-message-override-group': 'test_value_7',
'radius-server': 'test_value_8',
'security': 'open',
'usergroup': 'test_value_10',
'vdom': 'test_value_11',
'vlanid': '12'
}
set_method_mock.assert_called_with('switch-controller', 'vlan', data=expected_data, vdom='root')
schema_method_mock.assert_not_called()
assert is_error
assert not changed
assert response['status'] == 'error'
assert response['http_status'] == 500
def test_switch_controller_vlan_removal(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
delete_method_result = {'status': 'success', 'http_method': 'POST', 'http_status': 200}
delete_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.delete', return_value=delete_method_result)
input_data = {
'username': 'admin',
'state': 'absent',
'switch_controller_vlan': {
'auth': 'radius',
'color': '4',
'comments': 'test_value_5',
'name': 'default_name_6',
'portal_message_override_group': 'test_value_7',
'radius_server': 'test_value_8',
'security': 'open',
'usergroup': 'test_value_10',
'vdom': 'test_value_11',
'vlanid': '12'
},
'vdom': 'root'}
is_error, changed, response = fortios_switch_controller_vlan.fortios_switch_controller(input_data, fos_instance)
delete_method_mock.assert_called_with('switch-controller', 'vlan', mkey=ANY, vdom='root')
schema_method_mock.assert_not_called()
assert not is_error
assert changed
assert response['status'] == 'success'
assert response['http_status'] == 200
def test_switch_controller_vlan_deletion_fails(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
delete_method_result = {'status': 'error', 'http_method': 'POST', 'http_status': 500}
delete_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.delete', return_value=delete_method_result)
input_data = {
'username': 'admin',
'state': 'absent',
'switch_controller_vlan': {
'auth': 'radius',
'color': '4',
'comments': 'test_value_5',
'name': 'default_name_6',
'portal_message_override_group': 'test_value_7',
'radius_server': 'test_value_8',
'security': 'open',
'usergroup': 'test_value_10',
'vdom': 'test_value_11',
'vlanid': '12'
},
'vdom': 'root'}
is_error, changed, response = fortios_switch_controller_vlan.fortios_switch_controller(input_data, fos_instance)
delete_method_mock.assert_called_with('switch-controller', 'vlan', mkey=ANY, vdom='root')
schema_method_mock.assert_not_called()
assert is_error
assert not changed
assert response['status'] == 'error'
assert response['http_status'] == 500
def test_switch_controller_vlan_idempotent(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
set_method_result = {'status': 'error', 'http_method': 'DELETE', 'http_status': 404}
set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result)
input_data = {
'username': 'admin',
'state': 'present',
'switch_controller_vlan': {
'auth': 'radius',
'color': '4',
'comments': 'test_value_5',
'name': 'default_name_6',
'portal_message_override_group': 'test_value_7',
'radius_server': 'test_value_8',
'security': 'open',
'usergroup': 'test_value_10',
'vdom': 'test_value_11',
'vlanid': '12'
},
'vdom': 'root'}
is_error, changed, response = fortios_switch_controller_vlan.fortios_switch_controller(input_data, fos_instance)
expected_data = {
'auth': 'radius',
'color': '4',
'comments': 'test_value_5',
'name': 'default_name_6',
'portal-message-override-group': 'test_value_7',
'radius-server': 'test_value_8',
'security': 'open',
'usergroup': 'test_value_10',
'vdom': 'test_value_11',
'vlanid': '12'
}
set_method_mock.assert_called_with('switch-controller', 'vlan', data=expected_data, vdom='root')
schema_method_mock.assert_not_called()
assert not is_error
assert not changed
assert response['status'] == 'error'
assert response['http_status'] == 404
def test_switch_controller_vlan_filter_foreign_attributes(mocker):
schema_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.schema')
set_method_result = {'status': 'success', 'http_method': 'POST', 'http_status': 200}
set_method_mock = mocker.patch('ansible.module_utils.network.fortios.fortios.FortiOSHandler.set', return_value=set_method_result)
input_data = {
'username': 'admin',
'state': 'present',
'switch_controller_vlan': {
'random_attribute_not_valid': 'tag',
'auth': 'radius',
'color': '4',
'comments': 'test_value_5',
'name': 'default_name_6',
'portal_message_override_group': 'test_value_7',
'radius_server': 'test_value_8',
'security': 'open',
'usergroup': 'test_value_10',
'vdom': 'test_value_11',
'vlanid': '12'
},
'vdom': 'root'}
is_error, changed, response = fortios_switch_controller_vlan.fortios_switch_controller(input_data, fos_instance)
expected_data = {
'auth': 'radius',
'color': '4',
'comments': 'test_value_5',
'name': 'default_name_6',
'portal-message-override-group': 'test_value_7',
'radius-server': 'test_value_8',
'security': 'open',
'usergroup': 'test_value_10',
'vdom': 'test_value_11',
'vlanid': '12'
}
set_method_mock.assert_called_with('switch-controller', 'vlan', data=expected_data, vdom='root')
schema_method_mock.assert_not_called()
assert not is_error
assert changed
assert response['status'] == 'success'
assert response['http_status'] == 200
Write Preview
Loading…
Cancel
Save