mirror of https://github.com/ansible/ansible.git
Reduce chance of mistakes with unsafe_shell check during refactor
Code like this: if cond1 and cond2: pass elif cond1: pass Has a hidden dependency on the order that the conditions are checked. This makes them fragile and subject to breakage during refactors. Rewrite the code like this: if cond1: if cond2: pass else: pass The nested structure makes the ordering explicit and less likely for someone to break the code when they refactor.pull/30826/merge
parent
3e7b240696
commit
5f22b4f8ad
Loading…
Reference in New Issue