From 5d82fe545f0889b25b51ad199f7a8c924d63cfb7 Mon Sep 17 00:00:00 2001
From: Brian Coca <brian.coca+git@gmail.com>
Date: Fri, 16 Dec 2016 16:17:35 -0500
Subject: [PATCH] minor docs and option fixes

---
 lib/ansible/modules/packaging/os/portage.py | 22 ++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/lib/ansible/modules/packaging/os/portage.py b/lib/ansible/modules/packaging/os/portage.py
index 5debeda058c..af7c891a457 100644
--- a/lib/ansible/modules/packaging/os/portage.py
+++ b/lib/ansible/modules/packaging/os/portage.py
@@ -51,22 +51,22 @@ options:
     description:
       - Update packages to the best version available (--update)
     required: false
-    default: null
-    choices: [ "yes" ]
+    default: no
+    choices: [ "yes", "no" ]
 
   deep:
     description:
       - Consider the entire dependency tree of packages (--deep)
     required: false
-    default: null
-    choices: [ "yes" ]
+    default: no
+    choices: [ "yes", "no" ]
 
   newuse:
     description:
       - Include installed packages where USE flags have changed (--newuse)
     required: false
-    default: null
-    choices: [ "yes" ]
+    default: no
+    choices: [ "yes", "no" ]
 
   changed_use:
     description:
@@ -74,8 +74,8 @@ options:
       - flags that the user has not enabled are added or removed
       - (--changed-use)
     required: false
-    default: null
-    choices: [ "yes" ]
+    default: no
+    choices: [ "yes", "no" ]
     version_added: 1.8
 
   oneshot:
@@ -136,7 +136,7 @@ options:
       - If web, perform "emerge-webrsync"
     required: false
     default: null
-    choices: [ "yes", "web", "no" ]
+    choices: [ "web", "yes", "no" ]
 
   getbinpkg:
     description:
@@ -472,7 +472,7 @@ def main():
             depclean=dict(default=False, type='bool'),
             quiet=dict(default=False, type='bool'),
             verbose=dict(default=False, type='bool'),
-            sync=dict(default=None, choices=['yes', 'web']),
+            sync=dict(default=None, choices=['yes', 'web', 'no']),
             getbinpkg=dict(default=False, type='bool'),
             usepkgonly=dict(default=False, type='bool'),
             usepkg=dict(default=False, type='bool'),
@@ -490,7 +490,7 @@ def main():
 
     p = module.params
 
-    if p['sync']:
+    if p['sync'] and p['sync'].strip() != 'no':
         sync_repositories(module, webrsync=(p['sync'] == 'web'))
         if not p['package']:
             module.exit_json(msg='Sync successfully finished.')