From 5506229e7976d405fbbe56153e6a7a70512359d0 Mon Sep 17 00:00:00 2001 From: Dennis Glindhart Date: Fri, 9 Mar 2018 15:22:01 +0100 Subject: [PATCH] Remove restriction of SRV protocols (#36709) --- CHANGELOG.md | 1 + lib/ansible/modules/net_tools/cloudflare_dns.py | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 07073bbbcf8..5d4d60d2613 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,6 +14,7 @@ Ansible Changes By Release See [Porting Guide](http://docs.ansible.com/ansible/devel/porting_guides/porting_guides.html) for more information ### Minor Changes +* Removed restriction from protocol in cloudflare_dns module to allow other protocols than tcp and udp to be specified. * Ansible 2.6 and onwards, `target_id` parameter in `vmware_target_canonical_facts` module is an optional parameter. diff --git a/lib/ansible/modules/net_tools/cloudflare_dns.py b/lib/ansible/modules/net_tools/cloudflare_dns.py index 04d4ca46c65..fbd0e06ed89 100644 --- a/lib/ansible/modules/net_tools/cloudflare_dns.py +++ b/lib/ansible/modules/net_tools/cloudflare_dns.py @@ -42,9 +42,8 @@ options: required: false default: "1" proto: - description: Service protocol. Required for C(type=SRV) + description: Service protocol. Required for C(type=SRV). Common values are tcp and udp. (Before Ansible 2.6 only tcp and udp were available). required: false - choices: [ 'tcp', 'udp' ] default: null proxied: description: Proxy through cloudflare network or just use DNS @@ -602,7 +601,7 @@ def main(): account_email=dict(required=True, type='str'), port=dict(required=False, default=None, type='int'), priority=dict(required=False, default=1, type='int'), - proto=dict(required=False, default=None, choices=['tcp', 'udp'], type='str'), + proto=dict(required=False, default=None, type='str'), proxied=dict(required=False, default=False, type='bool'), record=dict(required=False, default='@', aliases=['name'], type='str'), service=dict(required=False, default=None, type='str'),