From 51e2813ae4cb125f10c2a3ed1edf647a58722494 Mon Sep 17 00:00:00 2001 From: hyperized Date: Wed, 13 Apr 2016 11:15:48 +0200 Subject: [PATCH] Set --quick to True by default and make it selectable (#3418) As indicated by @jmainguy in https://github.com/ansible/ansible-modules-core/commit/eb1cb94380281d114f84c571551fa164c2c18a09#commitcomment-17077470, this will allow the user to set the option quick, which is True by default (as it was before). This is in reference to: https://github.com/ansible/ansible-modules-core/pull/3402 --- lib/ansible/modules/database/mysql/mysql_db.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/ansible/modules/database/mysql/mysql_db.py b/lib/ansible/modules/database/mysql/mysql_db.py index ebdd1e00ef2..0d40be3dcce 100644 --- a/lib/ansible/modules/database/mysql/mysql_db.py +++ b/lib/ansible/modules/database/mysql/mysql_db.py @@ -66,7 +66,7 @@ options: description: - Option used for dumping large tables required: false - default: false + default: true version_added: "2.1" author: "Ansible Core Team" requirements: @@ -122,7 +122,6 @@ def db_dump(module, host, user, password, db_name, target, all_databases, port, # If defined, mysqldump demands --defaults-extra-file be the first option if config_file: cmd += " --defaults-extra-file=%s" % pipes.quote(config_file) - cmd += " --quick" if user is not None: cmd += " --user=%s" % pipes.quote(user) if password is not None: @@ -248,7 +247,7 @@ def main(): connect_timeout=dict(default=30, type='int'), config_file=dict(default="~/.my.cnf", type='path'), single_transaction=dict(default=False, type='bool'), - quick=dict(default=False, type='bool'), + quick=dict(default=True, type='bool'), ), supports_check_mode=True )