From 4f78b694f001a3234ece7024dfe92ecb0ddd0b17 Mon Sep 17 00:00:00 2001 From: Paul Belanger Date: Fri, 9 Aug 2019 16:47:08 -0400 Subject: [PATCH] Remove unused imports / variables from vyos modules (#60333) This code is not used, lets remove it. Signed-off-by: Paul Belanger --- lib/ansible/module_utils/network/vyos/facts/facts.py | 2 -- lib/ansible/modules/network/vyos/vyos_system.py | 2 +- lib/ansible/modules/network/vyos/vyos_user.py | 1 - lib/ansible/modules/network/vyos/vyos_vlan.py | 1 - 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/ansible/module_utils/network/vyos/facts/facts.py b/lib/ansible/module_utils/network/vyos/facts/facts.py index adfa0180cc1..c8df07a4e89 100644 --- a/lib/ansible/module_utils/network/vyos/facts/facts.py +++ b/lib/ansible/module_utils/network/vyos/facts/facts.py @@ -16,8 +16,6 @@ from ansible.module_utils.network.common.facts.facts import FactsBase from ansible.module_utils.network.vyos.facts.interfaces.interfaces import InterfacesFacts from ansible.module_utils.network.vyos.facts.l3_interfaces.l3_interfaces import L3_interfacesFacts from ansible.module_utils.network.vyos.facts.legacy.base import Default, Neighbors, Config -from ansible.module_utils. \ - network.vyos.vyos import run_commands, get_capabilities FACT_LEGACY_SUBSETS = dict( diff --git a/lib/ansible/modules/network/vyos/vyos_system.py b/lib/ansible/modules/network/vyos/vyos_system.py index 8afad21ea0b..fd9a0498b34 100644 --- a/lib/ansible/modules/network/vyos/vyos_system.py +++ b/lib/ansible/modules/network/vyos/vyos_system.py @@ -201,7 +201,7 @@ def main(): if commands: commit = not module.check_mode - response = load_config(module, commands, commit=commit) + load_config(module, commands, commit=commit) result['changed'] = True module.exit_json(**result) diff --git a/lib/ansible/modules/network/vyos/vyos_user.py b/lib/ansible/modules/network/vyos/vyos_user.py index cc3668ca78c..9a12318a44a 100644 --- a/lib/ansible/modules/network/vyos/vyos_user.py +++ b/lib/ansible/modules/network/vyos/vyos_user.py @@ -149,7 +149,6 @@ def validate_level(value, module): def spec_to_commands(updates, module): commands = list() - state = module.params['state'] update_password = module.params['update_password'] def needs_update(want, have, x): diff --git a/lib/ansible/modules/network/vyos/vyos_vlan.py b/lib/ansible/modules/network/vyos/vyos_vlan.py index b8a6f7fc7e4..93fd6bd9ad4 100644 --- a/lib/ansible/modules/network/vyos/vyos_vlan.py +++ b/lib/ansible/modules/network/vyos/vyos_vlan.py @@ -209,7 +209,6 @@ def map_params_to_obj(module): def map_config_to_obj(module): objs = [] - interfaces = list() output = run_commands(module, 'show interfaces') lines = output[0].strip().splitlines()[3:]