From 4f2d055e2cb3a99b98195244c796505d74b5d59d Mon Sep 17 00:00:00 2001 From: Jordan Borean Date: Tue, 12 Mar 2019 09:05:43 +1000 Subject: [PATCH] win_psexec - deprecate the extra_opts module options (#53666) --- docs/docsite/rst/porting_guides/porting_guide_2.8.rst | 2 ++ lib/ansible/modules/windows/win_psexec.ps1 | 2 +- lib/ansible/modules/windows/win_psexec.py | 2 ++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/docs/docsite/rst/porting_guides/porting_guide_2.8.rst b/docs/docsite/rst/porting_guides/porting_guide_2.8.rst index d1cd7bfd13d..4383778e5d7 100644 --- a/docs/docsite/rst/porting_guides/porting_guide_2.8.rst +++ b/docs/docsite/rst/porting_guides/porting_guide_2.8.rst @@ -316,6 +316,8 @@ Noteworthy module changes * The ``ipa_user`` module originally always sent ``password`` to FreeIPA regardless of whether the password changed. Now the module only sends ``password`` if ``update_password`` is set to ``always``, which is the default. +* The ``win_psexec`` has deprecated the undocumented ``extra_opts`` module option. This will be removed in Ansible 2.10. + Plugins ======= diff --git a/lib/ansible/modules/windows/win_psexec.ps1 b/lib/ansible/modules/windows/win_psexec.ps1 index 39853d9c25e..83e33422a89 100644 --- a/lib/ansible/modules/windows/win_psexec.ps1 +++ b/lib/ansible/modules/windows/win_psexec.ps1 @@ -27,7 +27,7 @@ $spec = @{ session = @{ type='int' } priority = @{ type='str'; choices=@( 'background', 'low', 'belownormal', 'abovenormal', 'high', 'realtime' ) } timeout = @{ type='int' } - extra_opts = @{ type='list' } + extra_opts = @{ type='list'; removed_in_version = '2.10' } } } diff --git a/lib/ansible/modules/windows/win_psexec.py b/lib/ansible/modules/windows/win_psexec.py index 7346a84f337..070ec1eb493 100644 --- a/lib/ansible/modules/windows/win_psexec.py +++ b/lib/ansible/modules/windows/win_psexec.py @@ -32,6 +32,8 @@ options: extra_opts: description: - Specify additional options to add onto the PsExec invocation. + - This module was undocumented in older releases and will be removed in + Ansible 2.10. type: list hostnames: description: