From 4c8d0b1b8d6823ecb453b7d5c08446f4f4900bcc Mon Sep 17 00:00:00 2001 From: GomathiselviS Date: Tue, 5 Nov 2019 07:51:13 -0500 Subject: [PATCH] eos_l2interfaces: Add unit testcases to eos_l2interfaces (#64127) * Add unit testcases to eos_l2interfaces * Fixed lint errors * Corrected lint errors --- .../eos/facts/l2_interfaces/l2_interfaces.py | 5 +- .../eos/fixtures/eos_l2_interfaces_config.cfg | 12 ++ .../network/eos/test_eos_l2_interfaces.py | 140 ++++++++++++++++++ 3 files changed, 156 insertions(+), 1 deletion(-) create mode 100644 test/units/modules/network/eos/fixtures/eos_l2_interfaces_config.cfg create mode 100644 test/units/modules/network/eos/test_eos_l2_interfaces.py diff --git a/lib/ansible/module_utils/network/eos/facts/l2_interfaces/l2_interfaces.py b/lib/ansible/module_utils/network/eos/facts/l2_interfaces/l2_interfaces.py index d2684a84cbe..bd68acb7622 100644 --- a/lib/ansible/module_utils/network/eos/facts/l2_interfaces/l2_interfaces.py +++ b/lib/ansible/module_utils/network/eos/facts/l2_interfaces/l2_interfaces.py @@ -37,6 +37,9 @@ class L2_interfacesFacts(object): self.generated_spec = utils.generate_dict(facts_argument_spec) + def get_device_data(self, connection): + return connection.get('show running-config | section ^interface') + def populate_facts(self, connection, ansible_facts, data=None): """ Populate the facts for l2_interfaces @@ -47,7 +50,7 @@ class L2_interfacesFacts(object): :returns: facts """ if not data: - data = connection.get('show running-config | section ^interface') + data = self.get_device_data(connection) # operate on a collection of resource x config = data.split('interface ') diff --git a/test/units/modules/network/eos/fixtures/eos_l2_interfaces_config.cfg b/test/units/modules/network/eos/fixtures/eos_l2_interfaces_config.cfg new file mode 100644 index 00000000000..08f75d18dbf --- /dev/null +++ b/test/units/modules/network/eos/fixtures/eos_l2_interfaces_config.cfg @@ -0,0 +1,12 @@ +interface Ethernet1 + switchport access vlan 20 +! +interface Ethernet2 + switchport trunk native vlan 20 + switchport mode trunk +! +interface Management1 + ip address dhcp + ipv6 address auto-config +! + diff --git a/test/units/modules/network/eos/test_eos_l2_interfaces.py b/test/units/modules/network/eos/test_eos_l2_interfaces.py new file mode 100644 index 00000000000..86adada9d03 --- /dev/null +++ b/test/units/modules/network/eos/test_eos_l2_interfaces.py @@ -0,0 +1,140 @@ +# +# (c) 2019, Ansible by Red Hat, inc +# GNU General Public License v3.0+ (see COPYING or https://www.gnu.org/licenses/gpl-3.0.txt) +# + +from __future__ import (absolute_import, division, print_function) +__metaclass__ = type + +from units.compat.mock import patch +from ansible.modules.network.eos import eos_l2_interfaces +from units.modules.utils import set_module_args +from .eos_module import TestEosModule, load_fixture + + +class TestEosL2InterfacesModule(TestEosModule): + module = eos_l2_interfaces + + def setUp(self): + super(TestEosL2InterfacesModule, self).setUp() + + self.mock_get_config = patch('ansible.module_utils.network.common.network.Config.get_config') + self.get_config = self.mock_get_config.start() + + self.mock_load_config = patch('ansible.module_utils.network.common.network.Config.load_config') + self.load_config = self.mock_load_config.start() + + self.mock_get_resource_connection_config = patch('ansible.module_utils.network.common.cfg.base.get_resource_connection') + self.get_resource_connection_config = self.mock_get_resource_connection_config.start() + + self.mock_get_resource_connection_facts = patch('ansible.module_utils.network.common.facts.facts.get_resource_connection') + self.get_resource_connection_facts = self.mock_get_resource_connection_facts.start() + + self.mock_edit_config = patch('ansible.module_utils.network.eos.providers.providers.CliProvider.edit_config') + self.edit_config = self.mock_edit_config.start() + + self.mock_execute_show_command = patch('ansible.module_utils.network.eos.facts.l2_interfaces.l2_interfaces.L2_interfacesFacts.get_device_data') + self.execute_show_command = self.mock_execute_show_command.start() + + def tearDown(self): + super(TestEosL2InterfacesModule, self).tearDown() + self.mock_get_resource_connection_config.stop() + self.mock_get_resource_connection_facts.stop() + self.mock_edit_config.stop() + self.mock_get_config.stop() + self.mock_load_config.stop() + self.mock_execute_show_command.stop() + + def load_fixtures(self, commands=None, transport='cli'): + def load_from_file(*args, **kwargs): + return load_fixture('eos_l2_interfaces_config.cfg') + self.execute_show_command.side_effect = load_from_file + + def test_eos_l2_interfaces_merged(self): + set_module_args(dict( + config=[dict( + name="Ethernet1", + trunk=dict(native_vlan=10) + ), dict( + name="Ethernet2", + access=dict(vlan=30), + )], state="merged" + )) + commands = ['interface Ethernet1', 'switchport trunk native vlan 10', + 'interface Ethernet2', 'switchport access vlan 30'] + self.execute_module(changed=True, commands=commands) + + def test_eos_l2_interfaces_merged_idempotent(self): + set_module_args(dict( + config=[dict( + name="Ethernet2", + trunk=dict(native_vlan=20) + ), dict( + name="Ethernet1", + access=dict(vlan=20), + )], state="merged" + )) + self.execute_module(changed=False, commands=[]) + + def test_eos_l2_interfaces_replaced(self): + set_module_args(dict( + config=[dict( + name="Ethernet2", + trunk=dict(native_vlan=50) + ), dict( + name="Ethernet3", + access=dict(vlan=30), + )], state="replaced" + )) + commands = ['interface Ethernet2', 'switchport trunk native vlan 50', + 'interface Ethernet3', 'switchport access vlan 30'] + self.execute_module(changed=True, commands=commands) + + def test_eos_l2_interfaces_replaced_idempotent(self): + set_module_args(dict( + config=[dict( + name="Ethernet2", + trunk=dict(native_vlan=20), + ), dict( + name="Ethernet1", + access=dict(vlan=20), + )], state="replaced" + )) + self.execute_module(changed=False, commands=[]) + + def test_eos_l2_interfaces_overridden(self): + set_module_args(dict( + config=[dict( + name="Ethernet2", + trunk=dict(native_vlan=50) + )], state="overridden" + )) + commands = ['interface Ethernet1', 'no switchport access vlan', + 'interface Ethernet2', 'switchport trunk native vlan 50'] + self.execute_module(changed=True, commands=commands) + + def test_eos_l2_interfaces_overridden_idempotent(self): + set_module_args(dict( + config=[dict( + name="Ethernet2", + trunk=dict(native_vlan=20) + ), dict( + name="Ethernet1", + access=dict(vlan=20), + )], state="overridden" + )) + self.execute_module(changed=False, commands=[]) + + def test_eos_l2_interfaces_deleted(self): + set_module_args(dict( + config=[dict( + name="Ethernet2", + trunk=dict(native_vlan=20) + ), dict( + name="Ethernet1", + access=dict(vlan=20), + )], state="deleted" + )) + commands = ['interface Ethernet1', 'no switchport access vlan', + 'interface Ethernet2', 'no switchport trunk native vlan'] + self.execute_module(changed=True, commands=commands)