From 491b67f114b571f329efbf4fbfd128f6b00585b9 Mon Sep 17 00:00:00 2001 From: Andrej Svenke Date: Tue, 24 Jan 2017 17:19:22 +0100 Subject: [PATCH] Fixed bug in ecs_taskdefinition for new task with forced revision 1. (#20561) --- lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py b/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py index 2c7ede7ed68..0d68921aced 100644 --- a/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py +++ b/lib/ansible/modules/cloud/amazon/ecs_taskdefinition.py @@ -255,9 +255,9 @@ def main(): # We cannot reactivate an inactive revision module.fail_json(msg="A task in family '%s' already exists for revsion %d, but it is inactive" % (family, revision)) elif not existing: - if len(existing_definitions_in_family) == 0 and revision != 1: + if not existing_definitions_in_family and revision != 1: module.fail_json(msg="You have specified a revision of %d but a created revision would be 1" % revision) - elif existing_definitions_in_family[-1]['revision'] + 1 != revision: + elif existing_definitions_in_family and existing_definitions_in_family[-1]['revision'] + 1 != revision: module.fail_json(msg="You have specified a revision of %d but a created revision would be %d" % (revision, existing_definitions_in_family[-1]['revision'] + 1)) else: existing = None