From 4706af58ab121087a8ef0910345a29615e639ad5 Mon Sep 17 00:00:00 2001 From: Matt Clay Date: Fri, 3 Feb 2023 15:19:35 -0800 Subject: [PATCH] ansible-test - Enable trailing-comma-tuple pylint rule (#79909) --- .../fragments/ansible-test-pylint-trailing-comma-tuple.yml | 2 ++ .../_util/controller/sanity/pylint/config/collection.cfg | 2 -- .../_util/controller/sanity/pylint/config/default.cfg | 2 -- test/sanity/ignore.txt | 1 + 4 files changed, 3 insertions(+), 4 deletions(-) create mode 100644 changelogs/fragments/ansible-test-pylint-trailing-comma-tuple.yml diff --git a/changelogs/fragments/ansible-test-pylint-trailing-comma-tuple.yml b/changelogs/fragments/ansible-test-pylint-trailing-comma-tuple.yml new file mode 100644 index 00000000000..006200517c6 --- /dev/null +++ b/changelogs/fragments/ansible-test-pylint-trailing-comma-tuple.yml @@ -0,0 +1,2 @@ +minor_changes: + - ansible-test - Enable the ``trailing-comma-tuple`` rule in the ``pylint`` sanity test. diff --git a/test/lib/ansible_test/_util/controller/sanity/pylint/config/collection.cfg b/test/lib/ansible_test/_util/controller/sanity/pylint/config/collection.cfg index 78064542f90..627c80298cf 100644 --- a/test/lib/ansible_test/_util/controller/sanity/pylint/config/collection.cfg +++ b/test/lib/ansible_test/_util/controller/sanity/pylint/config/collection.cfg @@ -96,8 +96,6 @@ disable= too-many-public-methods, too-many-return-statements, too-many-statements, - trailing-comma-tuple, - trailing-comma-tuple, try-except-raise, unbalanced-tuple-unpacking, undefined-loop-variable, diff --git a/test/lib/ansible_test/_util/controller/sanity/pylint/config/default.cfg b/test/lib/ansible_test/_util/controller/sanity/pylint/config/default.cfg index 00b31ece78b..1832f734acf 100644 --- a/test/lib/ansible_test/_util/controller/sanity/pylint/config/default.cfg +++ b/test/lib/ansible_test/_util/controller/sanity/pylint/config/default.cfg @@ -92,8 +92,6 @@ disable= too-many-public-methods, too-many-return-statements, too-many-statements, - trailing-comma-tuple, - trailing-comma-tuple, try-except-raise, unbalanced-tuple-unpacking, undefined-loop-variable, diff --git a/test/sanity/ignore.txt b/test/sanity/ignore.txt index b0de6515b46..0c378d6566a 100644 --- a/test/sanity/ignore.txt +++ b/test/sanity/ignore.txt @@ -102,6 +102,7 @@ lib/ansible/module_utils/six/__init__.py no-dict-iteritems lib/ansible/module_utils/six/__init__.py no-dict-iterkeys lib/ansible/module_utils/six/__init__.py no-dict-itervalues lib/ansible/module_utils/six/__init__.py pylint:self-assigning-variable +lib/ansible/module_utils/six/__init__.py pylint:trailing-comma-tuple lib/ansible/module_utils/six/__init__.py replace-urlopen lib/ansible/module_utils/urls.py pylint:arguments-renamed lib/ansible/module_utils/urls.py pylint:disallowed-name